Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Overall LGTM with some nits.
libc/src/__support/integer_to_string.h | ||
---|---|---|
27 | This should be false for uppercase. | |
153 | instead of specifying false here, you could leave this blank since lowercase has a default value already. Same below. | |
libc/src/__support/threads/linux/thread.cpp | ||
279–280 | you could use dec_bufsize<int> here | |
libc/src/stdio/printf_core/int_converter.h | ||
68–69 | you could use oct_bufsize<intmax_t> here |
This should be false for uppercase.