This is an archive of the discontinued LLVM Phabricator instance.

Differential D131889

[libc++][test] Fix conversion signed/unsigned in test/support/MoveOnly.h
ClosedPublic

Authored by fsb4000 on Aug 15 2022, 6:35 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGf7f5308b8295: [libc++][test] Fix conversion signed/unsigned in test/support/MoveOnly.h

Diff Detail

Event Timeline

fsb4000 created this revision.Aug 15 2022, 6:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2022, 6:35 AM
fsb4000 requested review of this revision.Aug 15 2022, 6:35 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2022, 6:35 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
jloser added a subscriber: jloser.Aug 15 2022, 7:00 AM

LGTM!

philnik accepted this revision.Aug 15 2022, 7:08 AM
This revision is now accepted and ready to land.Aug 15 2022, 7:08 AM
This revision was landed with ongoing or failed builds.Aug 15 2022, 8:11 AM
Closed by commit rGf7f5308b8295: [libc++][test] Fix conversion signed/unsigned in test/support/MoveOnly.h (authored by fsb4000). · Explain Why
This revision was automatically updated to reflect the committed changes.
fsb4000 added a commit: rGf7f5308b8295: [libc++][test] Fix conversion signed/unsigned in test/support/MoveOnly.h.
Harbormaster completed remote builds in B181269: Diff 452651.Aug 15 2022, 9:55 AM

Revision Contents

PathSize
libcxx/
test/
support/
2 lines

Diff 452674

libcxx/test/support/MoveOnly.h

Show First 20 Lines • Show All 56 Lines • ▼ Show 20 Lines
}; };
template <> template <>
struct std::hash<MoveOnly> struct std::hash<MoveOnly>
{ {
typedef MoveOnly argument_type; typedef MoveOnly argument_type;
typedef size_t result_type; typedef size_t result_type;
TEST_CONSTEXPR size_t operator()(const MoveOnly& x) const {return x.get();} TEST_CONSTEXPR size_t operator()(const MoveOnly& x) const {return static_cast<size_t>(x.get());}
}; };
#endif // MOVEONLY_H #endif // MOVEONLY_H