Page MenuHomePhabricator

[MSAN] Correct shadow type for atomicrmw instrumentation
ClosedPublic

Authored by loladiro on Aug 13 2022, 5:35 PM.

Details

Summary

We were passing the type of Val to getShadowOriginPtr, rather
than the type of Val's shadow resulting in broken IR. The fix
is simple.

Diff Detail

Event Timeline

loladiro created this revision.Aug 13 2022, 5:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2022, 5:35 PM
loladiro requested review of this revision.Aug 13 2022, 5:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2022, 5:35 PM
loladiro updated this revision to Diff 452468.Aug 13 2022, 7:11 PM

fixup CHECKs

eugenis accepted this revision.Aug 23 2022, 6:15 PM

LGTM

This revision is now accepted and ready to land.Aug 23 2022, 6:15 PM
This revision was automatically updated to reflect the committed changes.