This is an archive of the discontinued LLVM Phabricator instance.

Differential D131724

[pseudo] Eliminate an ambiguity for the empty member declaration.
ClosedPublic

Authored by hokein on Aug 11 2022, 2:16 PM.

Details

Reviewers
kadircet
Commits
rGa1a1a78ac8cf: [pseudo] Eliminate an ambiguity for the empty member declaration.
Summary

We happened to introduce a member-declaration := ; rule
when inlining the `member-declaration := decl-specifier-seq_opt
member-declarator-list_opt ;`.
And with the member-declaration := empty-declaration rule, we had two parses of ;.

This patch is to restrict the grammar to eliminate the
member-declaration := ; rule.

Diff Detail

Event Timeline

hokein created this revision.Aug 11 2022, 2:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 2:16 PM
hokein requested review of this revision.Aug 11 2022, 2:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 2:16 PM
Herald added a subscriber: alextsao1999. · View Herald Transcript
Harbormaster completed remote builds in B180778: Diff 451982.Aug 11 2022, 4:11 PM
kadircet accepted this revision.Aug 12 2022, 3:25 AM

thanks!

This revision is now accepted and ready to land.Aug 12 2022, 3:25 AM
This revision was landed with ongoing or failed builds.Aug 12 2022, 4:47 AM
Closed by commit rGa1a1a78ac8cf: [pseudo] Eliminate an ambiguity for the empty member declaration. (authored by hokein). · Explain Why
This revision was automatically updated to reflect the committed changes.
hokein added a commit: rGa1a1a78ac8cf: [pseudo] Eliminate an ambiguity for the empty member declaration..

Revision Contents

PathSize
clang-tools-extra/
pseudo/
lib/
cxx/
3 lines
test/
cxx/
7 lines

Diff 451982

clang-tools-extra/pseudo/lib/cxx/cxx.bnf

Show First 20 Lines • Show All 551 Lines • ▼ Show 20 Lines
class-head := class-key base-clause_opt class-head := class-key base-clause_opt
class-head-name := nested-name-specifier_opt class-name class-head-name := nested-name-specifier_opt class-name
class-virt-specifier := contextual-final class-virt-specifier := contextual-final
class-key := CLASS class-key := CLASS
class-key := STRUCT class-key := STRUCT
class-key := UNION class-key := UNION
member-specification := member-declaration member-specification_opt member-specification := member-declaration member-specification_opt
member-specification := access-specifier : member-specification_opt member-specification := access-specifier : member-specification_opt
member-declaration := decl-specifier-seq_opt member-declarator-list_opt ; member-declaration := decl-specifier-seq member-declarator-list_opt ;
member-declaration := member-declarator-list ;
member-declaration := function-definition member-declaration := function-definition
member-declaration := using-declaration member-declaration := using-declaration
member-declaration := using-enum-declaration member-declaration := using-enum-declaration
member-declaration := static_assert-declaration member-declaration := static_assert-declaration
member-declaration := template-declaration member-declaration := template-declaration
member-declaration := explicit-specialization member-declaration := explicit-specialization
member-declaration := deduction-guide member-declaration := deduction-guide
member-declaration := alias-declaration member-declaration := alias-declaration
▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines

clang-tools-extra/pseudo/test/cxx/empty-member-declaration.cpp

  • This file was added.
// RUN: clang-pseudo -grammar=cxx -source=%s --print-forest --forest-abbrev=false | FileCheck %s
class A {
;
// CHECK-NOT: member-declaration := ;
// CHECK: member-declaration := empty-declaration
// CHECK-NOT: member-declaration := ;
};