Page MenuHomePhabricator

[ELF2] Use static non-member function when it suffices
ClosedPublic

Authored by davide on Sep 24 2015, 7:20 PM.

Details

Reviewers
ruiu
Summary

Try to address Rui's comment on my previous commit.

Diff Detail

Event Timeline

davide updated this revision to Diff 35694.Sep 24 2015, 7:20 PM
davide retitled this revision from to [ELF2] Use static non-member function when it suffices.
davide updated this object.
davide added a reviewer: ruiu.
davide set the repository for this revision to rL LLVM.
davide added a subscriber: llvm-commits.
ruiu accepted this revision.Sep 24 2015, 7:26 PM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 24 2015, 7:26 PM
shankare added inline comments.
ELF/Writer.cpp
339–340

what if discard all and discard none is used ? Do we plan to print any warning of what option was chosen ?

davide closed this revision.Sep 24 2015, 8:58 PM