This is an archive of the discontinued LLVM Phabricator instance.

Improve error reporting for failing to find argdumper.
ClosedPublic

Authored by brucem on Sep 24 2015, 12:00 AM.

Reviewers

Commits

brucem retitled this revision from to Improve error reporting for failing to find argdumper..

brucem updated this object.

brucem added a subscriber: lldb-commits.

ki.stfu added a reviewer: ki.stfu.

This revision is now accepted and ready to land.Sep 24 2015, 12:02 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

Host/

macosx/

4 lines

	Show First 20 Lines • Show All 1,339 Lines • ▼ Show 20 Lines
	Host::ShellExpandArguments (ProcessLaunchInfo &launch_info)			Host::ShellExpandArguments (ProcessLaunchInfo &launch_info)
	{			{
	Error error;			Error error;
	if (launch_info.GetFlags().Test(eLaunchFlagShellExpandArguments))			if (launch_info.GetFlags().Test(eLaunchFlagShellExpandArguments))
	{			{
	FileSpec expand_tool_spec;			FileSpec expand_tool_spec;
	if (!HostInfo::GetLLDBPath(lldb::ePathTypeSupportExecutableDir, expand_tool_spec))			if (!HostInfo::GetLLDBPath(lldb::ePathTypeSupportExecutableDir, expand_tool_spec))
	{			{
	error.SetErrorString("could not find argdumper tool");			error.SetErrorString("could not get support executable directory for argdumper tool");
	return error;			return error;
	}			}
	expand_tool_spec.AppendPathComponent("argdumper");			expand_tool_spec.AppendPathComponent("argdumper");
	if (!expand_tool_spec.Exists())			if (!expand_tool_spec.Exists())
	{			{
	error.SetErrorString("could not find argdumper tool");			error.SetErrorStringWithFormat("could not find argdumper tool: %s", expand_tool_spec.GetPath().c_str());
	return error;			return error;
	}			}

	Args expand_command(expand_tool_spec.GetPath().c_str());			Args expand_command(expand_tool_spec.GetPath().c_str());
	expand_command.AppendArguments (launch_info.GetArguments());			expand_command.AppendArguments (launch_info.GetArguments());

	int status;			int status;
	std::string output;			std::string output;
	▲ Show 20 Lines • Show All 193 Lines • Show Last 20 Lines