[orc-rt] Fix swift protocol metadata registration

[benlangmuir]

Summary

The swif5_proto and swift5_protos sections had their meaning
inverted. Fix, and rename the arrays so it is more obvious which is
which.

[lhames]

Oof -- how embarrassing for whoever was responsible.
<.<

.>

LGTM.

compiler-rt/lib/orc/macho_platform.cpp

struct JITDylibState {
     AtExitsVector AtExits;
     const objc_image_info *ObjCImageInfo = nullptr;
     std::vector<span<void (*)()>> ModInitsSections;
     std::vector<span<void (*)()>> ModInitsSectionsNew;
     std::vector<span<uintptr_t>> ObjCClassListSections;
     std::vector<span<uintptr_t>> ObjCClassListSectionsNew;
     std::vector<span<uintptr_t>> ObjCSelRefsSections;
     std::vector<span<uintptr_t>> ObjCSelRefsSectionsNew;
-    std::vector<span<char>> Swift5ProtoSections;
-    std::vector<span<char>> Swift5ProtoSectionsNew;
-    std::vector<span<char>> Swift5ProtosSections;
-    std::vector<span<char>> Swift5ProtosSectionsNew;
+    std::vector<span<char>> Swift5ProtocolsSections;
+    std::vector<span<char>> Swift5ProtocolsSectionsNew;
+    std::vector<span<char>> Swift5ProtocolConformancesSections;
+    std::vector<span<char>> Swift5ProtocolConformancesSectionsNew;
     std::vector<span<char>> Swift5TypesSections;
     std::vector<span<char>> Swift5TypesSectionsNew;
 
     bool referenced() const {
       return LinkedAgainstRefCount != 0 || DlRefCount != 0;
     }
   };
 
for (auto &KV : Secs) {
     if (KV.first == "__DATA,__thread_data") {
       if (auto Err = registerThreadDataSection(KV.second.toSpan<const char>()))
         return Err;
     } else if (KV.first == "__DATA,__objc_selrefs")
       JDS->ObjCSelRefsSectionsNew.push_back(KV.second.toSpan<uintptr_t>());
     else if (KV.first == "__DATA,__objc_classlist")
       JDS->ObjCClassListSectionsNew.push_back(KV.second.toSpan<uintptr_t>());
     else if (KV.first == "__TEXT,__swift5_protos")
-      JDS->Swift5ProtosSectionsNew.push_back(KV.second.toSpan<char>());
+      JDS->Swift5ProtocolsSectionsNew.push_back(KV.second.toSpan<char>());
     else if (KV.first == "__TEXT,__swift5_proto")
-      JDS->Swift5ProtoSectionsNew.push_back(KV.second.toSpan<char>());
+      JDS->Swift5ProtocolConformancesSectionsNew.push_back(
+          KV.second.toSpan<char>());
     else if (KV.first == "__TEXT,__swift5_types")
       JDS->Swift5TypesSectionsNew.push_back(KV.second.toSpan<char>());
     else if (KV.first == "__DATA,__mod_init_func")
       JDS->ModInitsSectionsNew.push_back(KV.second.toSpan<void (*)()>());
     else {
       // Should this be a warning instead?
       return make_error<StringError>(
           "Encountered unexpected section " +
if (KV.first == "__DATA,__thread_data") {
         return Err;
     } else if (KV.first == "__DATA,__objc_selrefs") {
       if (!removeIfPresent(JDS->ObjCSelRefsSections, KV.second))
         removeIfPresent(JDS->ObjCSelRefsSectionsNew, KV.second);
     } else if (KV.first == "__DATA,__objc_classlist") {
       if (!removeIfPresent(JDS->ObjCClassListSections, KV.second))
         removeIfPresent(JDS->ObjCClassListSectionsNew, KV.second);
     } else if (KV.first == "__TEXT,__swift5_protos") {
-      if (!removeIfPresent(JDS->Swift5ProtosSections, KV.second))
-        removeIfPresent(JDS->Swift5ProtosSectionsNew, KV.second);
+      if (!removeIfPresent(JDS->Swift5ProtocolsSections, KV.second))
+        removeIfPresent(JDS->Swift5ProtocolsSectionsNew, KV.second);
     } else if (KV.first == "__TEXT,__swift5_proto") {
-      if (!removeIfPresent(JDS->Swift5ProtoSections, KV.second))
-        removeIfPresent(JDS->Swift5ProtoSectionsNew, KV.second);
+      if (!removeIfPresent(JDS->Swift5ProtocolConformancesSections, KV.second))
+        removeIfPresent(JDS->Swift5ProtocolConformancesSectionsNew, KV.second);
     } else if (KV.first == "__TEXT,__swift5_types") {
       if (!removeIfPresent(JDS->Swift5TypesSections, KV.second))
         removeIfPresent(JDS->Swift5TypesSectionsNew, KV.second);
     } else if (KV.first == "__DATA,__mod_init_func") {
       if (!removeIfPresent(JDS->ModInitsSections, KV.second))
         removeIfPresent(JDS->ModInitsSectionsNew, KV.second);
     } else {
       // Should this be a warning instead?
Error MachOPlatformRuntimeState::registerObjCClasses(JITDylibState &JDS) {
   }
 
   moveAppendSections(JDS.ObjCClassListSections, JDS.ObjCClassListSectionsNew);
   return Error::success();
 }
 
 Error MachOPlatformRuntimeState::registerSwift5Protocols(JITDylibState &JDS) {
 
-  if (JDS.Swift5ProtosSectionsNew.empty())
+  if (JDS.Swift5ProtocolsSectionsNew.empty())
     return Error::success();
 
   if (ORC_RT_UNLIKELY(!swift_registerProtocols))
     return make_error<StringError>("swift_registerProtocols is not available");
 
-  for (const auto &Swift5Protocols : JDS.Swift5ProtoSectionsNew)
+  for (const auto &Swift5Protocols : JDS.Swift5ProtocolsSectionsNew)
     swift_registerProtocols(
         reinterpret_cast<const ProtocolRecord *>(Swift5Protocols.data()),
         reinterpret_cast<const ProtocolRecord *>(Swift5Protocols.data() +
                                                  Swift5Protocols.size()));
 
-  moveAppendSections(JDS.Swift5ProtoSections, JDS.Swift5ProtoSectionsNew);
+  moveAppendSections(JDS.Swift5ProtocolsSections,
+                     JDS.Swift5ProtocolsSectionsNew);
   return Error::success();
 }
 
 Error MachOPlatformRuntimeState::registerSwift5ProtocolConformances(
     JITDylibState &JDS) {
 
-  if (JDS.Swift5ProtosSectionsNew.empty())
+  if (JDS.Swift5ProtocolConformancesSectionsNew.empty())
     return Error::success();
 
   if (ORC_RT_UNLIKELY(!swift_registerProtocolConformances))
     return make_error<StringError>(
         "swift_registerProtocolConformances is not available");
 
-  for (const auto &ProtoConfSec : JDS.Swift5ProtosSectionsNew)
+  for (const auto &ProtoConfSec : JDS.Swift5ProtocolConformancesSectionsNew)
     swift_registerProtocolConformances(
         reinterpret_cast<const ProtocolConformanceRecord *>(
             ProtoConfSec.data()),
         reinterpret_cast<const ProtocolConformanceRecord *>(
             ProtoConfSec.data() + ProtoConfSec.size()));
 
-  moveAppendSections(JDS.Swift5ProtosSections, JDS.Swift5ProtosSectionsNew);
+  moveAppendSections(JDS.Swift5ProtocolConformancesSections,
+                     JDS.Swift5ProtocolConformancesSectionsNew);
   return Error::success();
 }
 
 Error MachOPlatformRuntimeState::registerSwift5Types(JITDylibState &JDS) {
 
   if (JDS.Swift5TypesSectionsNew.empty())
     return Error::success();