[libcxx][test] fix allocator in allocator_propagation test

[CaseyCarter]

Summary

The converting constructor is ill-formed, and == is missing. (I didn't implement != since the test is C++20-and-later only; I'll let the compiler do it for us.)

Drive-by: change 4-space indent on line 27 to 2-space indent to be consistent with the rest of the test.

[philnik]

Please don't land unreviewed libc++ patches. If you need to land it for some reason, please ping instead of just committing.

libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/allocator_propagation.pass.cpp

27

This indentation was correct. We indent initializers four spaces.

[CaseyCarter]

In D131079#4027290, @philnik wrote:

Please don't land unreviewed libc++ patches. If you need to land it for some reason, please ping instead of just committing.

Fair enough. Now that I've proven I can't correctly determine when a change is small and simple enough for post-commit review, I'll post everything. I've submitted https://reviews.llvm.org/D141157 to revert the indentation damage.

libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/allocator_propagation.pass.cpp

 class soccc_allocator {
   int* soccc_count;
   int self_soccc_count;
 
 public:
   using value_type = T;
 
   constexpr explicit soccc_allocator(int* soccc_count_, int self_coccc_count_ = 0)
-      : soccc_count(soccc_count_), self_soccc_count(self_coccc_count_) {}
 
   template <class U>
-  constexpr soccc_allocator(const soccc_allocator<U>& a) : soccc_count(a.soccc_count) {}
+  constexpr soccc_allocator(const soccc_allocator<U>& a) : soccc_count(a.get_soccc()) {}
 
   constexpr T* allocate(std::size_t n) { return std::allocator<T>().allocate(n); }
   constexpr void deallocate(T* p, std::size_t s) { std::allocator<T>().deallocate(p, s); }
 
   constexpr soccc_allocator select_on_container_copy_construction() const {
     *soccc_count += 1;
     return soccc_allocator(soccc_count, self_soccc_count + 1);
   }
 
-  constexpr auto get_soccc() { return soccc_count; }
-  constexpr auto get_self_soccc() { return self_soccc_count; }
+  constexpr auto get_soccc() const { return soccc_count; }
+  constexpr auto get_self_soccc() const { return self_soccc_count; }
 
   typedef std::true_type propagate_on_container_copy_assignment;
   typedef std::true_type propagate_on_container_move_assignment;
   typedef std::true_type propagate_on_container_swap;
+
+  template <class U>
+  constexpr bool operator==(const soccc_allocator<U>& that) const {
+    return soccc_count == that.get_soccc();
+  }
 };
 
 template <class CharT>
 TEST_CONSTEXPR_CXX20 bool test() {
   using S = std::basic_string<CharT, std::char_traits<CharT>, soccc_allocator<CharT>>;
   {
     int soccc_lhs = 0;
     int soccc_rhs = 0;