This is an archive of the discontinued LLVM Phabricator instance.

Libfuzzer fix for Ctrl + c not working with -fork and -ignore_crashes=1
ClosedPublic

Authored by SyrasX on Aug 2 2022, 7:26 AM.

Details

Summary

In some cases running Libfuzzer in fork mode with -ignore_crashes=1 counts ctrl+c as crash and restarts.

Thread: https://github.com/google/oss-fuzz/issues/4547

Credit: Marcel Boehme <marcel.boehme@acm.org>

Diff Detail

Event Timeline

SyrasX created this revision.Aug 2 2022, 7:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2022, 7:26 AM
Herald added a subscriber: Enna1. · View Herald Transcript
SyrasX requested review of this revision.Aug 2 2022, 7:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2022, 7:26 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka added inline comments.Aug 3 2022, 5:01 PM
compiler-rt/lib/fuzzer/FuzzerUtilLinux.cpp
29

why this does not use Options->InterruptExitCode?

SyrasX updated this revision to Diff 449952.Aug 4 2022, 6:18 AM

FuzzingOptions->InterruptExitCode

SyrasX marked an inline comment as done.Aug 4 2022, 6:21 AM
SyrasX added inline comments.
compiler-rt/lib/fuzzer/FuzzerUtilLinux.cpp
29

Yeah just inattention sorry.

vitalybuka accepted this revision.Aug 12 2022, 4:09 PM
This revision is now accepted and ready to land.Aug 12 2022, 4:09 PM
SyrasX marked an inline comment as done.Aug 13 2022, 8:33 AM

Is there anything I need to do after the diff got accepted ? Don't think I have a way to commit. @vitalybuka

I can land it for you, but can't figure out email to attach to the commit.

I can land it for you, but can't figure out email to attach to the commit.

Thanks, should be maxim.schessler@gmail.com

This revision was landed with ongoing or failed builds.Aug 16 2022, 4:45 PM
This revision was automatically updated to reflect the committed changes.