Page MenuHomePhabricator

Support recent versions of Ubuntu
AbandonedPublic

Authored by sylvestre.ledru on Sep 23 2015, 12:57 AM.

Details

Reviewers
samsonov
Summary

On Ubuntu i386, unlike Debian, the TargetArch has been renamed for i585 or i686 depending on the
arch. This patch enables compiler-rt to build on these archs.

Diff Detail

Event Timeline

sylvestre.ledru retitled this revision from to Support recent versions of Ubuntu.
sylvestre.ledru updated this object.
sylvestre.ledru added a reviewer: samsonov.
samsonov edited edge metadata.Sep 23 2015, 11:31 AM

So, after this change you will build libclang_rt.i386.a on i586 or i686. Will it be properly picked up by the Clang driver?

make/platform/clang_linux.mk
22

Update a comment

24

Please keep this list sorted.

38

Can you use call contains here as well?

samsonov edited edge metadata.Sep 23 2015, 11:32 AM
samsonov added a subscriber: llvm-commits.

Implement Alexey requests

. Will it be properly picked up by the Clang driver?

Seems not. I will have a look.

. Will it be properly picked up by the Clang driver?

Seems not. I will have a look.

OK, please report here then. I'm afraid Clang on i586 would look for the runtime with "i586" in its name, not "i386".

sylvestre.ledru abandoned this revision.Nov 12 2016, 1:42 AM

moved to cmake!