Page MenuHomePhabricator

[TSan][Darwin] Additional TSAN test requiring weak symbol for dyld64
ClosedPublic

Authored by thetruestblue on Jul 28 2022, 2:48 PM.

Details

Summary

Tests require a weak symbol for dyld weak-def coalescing.

Diff Detail

Event Timeline

thetruestblue created this revision.Jul 28 2022, 2:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2022, 2:48 PM
Herald added a subscriber: Enna1. · View Herald Transcript
thetruestblue requested review of this revision.Jul 28 2022, 2:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2022, 2:48 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rsundahl accepted this revision.Jul 28 2022, 2:56 PM
This revision is now accepted and ready to land.Jul 28 2022, 2:56 PM

@rsundahl do we think I should add weak attribute to OnPotentiallyBlockingRegionEnd as well? or leave as is?

yln added a comment.Jul 29 2022, 10:03 AM

@rsundahl do we think I should add weak attribute to OnPotentiallyBlockingRegionEnd as well? or leave as is?

Yes, it's the same mechanism (consistency), even if we don't need to make the test pass.

This comment was removed by thetruestblue.

Additional weak def

rsundahl accepted this revision.Jul 29 2022, 11:12 AM

LGTM! Thanks for finding this one!

@rsundahl do we think I should add weak attribute to OnPotentiallyBlockingRegionEnd as well? or leave as is?

I agree with @yln here @thetruestblue. In this case, better to be consistent.