This is an archive of the discontinued LLVM Phabricator instance.

Differential D130707

[llvm-reduce] Split operands-skip.ll into serial and parallel parts
ClosedPublic

Authored by DavidSpickett on Jul 28 2022, 7:21 AM.

Details

Reviewers
fhahn
Commits
rG7ce321e5b0a4: [llvm-reduce] Split operands-skip.ll into serial and parallel parts
Summary

This fixes a test failure when building with LLVM_ENABLE_THREADS=OFF.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jul 28 2022, 7:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2022, 7:21 AM
DavidSpickett requested review of this revision.Jul 28 2022, 7:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2022, 7:21 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
DavidSpickett updated this revision to Diff 448339.Jul 28 2022, 7:37 AM

Instead of copying the file, use the original one as the input for the parallel test.

DavidSpickett added a reviewer: fhahn.Jul 28 2022, 7:38 AM
Harbormaster completed remote builds in B178077: Diff 448339.Jul 28 2022, 8:20 AM
DavidSpickett added a comment.Aug 3 2022, 6:09 AM

ping!

fhahn accepted this revision.Aug 3 2022, 9:30 AM

LGTM, thanks!

llvm/test/tools/llvm-reduce/operands-skip-parallel.ll
3

nit: Might be good to add a comment that this re-uses llvm/test/tools/llvm-reduce/operands-skip.ll

This revision is now accepted and ready to land.Aug 3 2022, 9:30 AM
This revision was landed with ongoing or failed builds.Aug 4 2022, 1:51 AM
Closed by commit rG7ce321e5b0a4: [llvm-reduce] Split operands-skip.ll into serial and parallel parts (authored by DavidSpickett). · Explain Why
This revision was automatically updated to reflect the committed changes.
DavidSpickett added a commit: rG7ce321e5b0a4: [llvm-reduce] Split operands-skip.ll into serial and parallel parts.
DavidSpickett marked an inline comment as done.Aug 4 2022, 1:52 AM

Revision Contents

PathSize
llvm/
test/
tools/
llvm-reduce/
8 lines
7 lines

Diff 449903

llvm/test/tools/llvm-reduce/operands-skip-parallel.ll

  • This file was added.
; This reuses llvm/test/tools/llvm-reduce/operands-skip.ll
; REQUIRES: thread_support
fhahnUnsubmitted
Done
ReplyInline Actions

nit: Might be good to add a comment that this re-uses llvm/test/tools/llvm-reduce/operands-skip.ll

fhahn: nit: Might be good to add a comment that this re-uses `llvm/test/tools/llvm-reduce/operands…
; RUN: llvm-reduce -j 2 %S/operands-skip.ll -o %t.1 --delta-passes=operands-skip --test FileCheck --test-arg %S/operands-skip.ll --test-arg --match-full-lines --test-arg --check-prefix=INTERESTING --test-arg --input-file
; RUN: FileCheck %S/operands-skip.ll --input-file %t.1 --check-prefixes=REDUCED
; RUN: llvm-reduce -j 4 %S/operands-skip.ll -o %t.2 --delta-passes=operands-skip --test FileCheck --test-arg %S/operands-skip.ll --test-arg --match-full-lines --test-arg --check-prefix=INTERESTING --test-arg --input-file
; RUN: FileCheck %S/operands-skip.ll --input-file %t.2 --check-prefixes=REDUCED

llvm/test/tools/llvm-reduce/operands-skip.ll

; RUN: llvm-reduce %s -o %t --delta-passes=operands-skip --test FileCheck --test-arg %s --test-arg --match-full-lines --test-arg --check-prefix=INTERESTING --test-arg --input-file ; RUN: llvm-reduce %s -o %t --delta-passes=operands-skip --test FileCheck --test-arg %s --test-arg --match-full-lines --test-arg --check-prefix=INTERESTING --test-arg --input-file
; RUN: FileCheck %s --input-file %t --check-prefixes=REDUCED ; RUN: FileCheck %s --input-file %t --check-prefixes=REDUCED
; RUN: llvm-reduce -j 2 %s -o %t.1 --delta-passes=operands-skip --test FileCheck --test-arg %s --test-arg --match-full-lines --test-arg --check-prefix=INTERESTING --test-arg --input-file
; RUN: FileCheck %s --input-file %t.1 --check-prefixes=REDUCED
; RUN: llvm-reduce -j 4 %s -o %t.2 --delta-passes=operands-skip --test FileCheck --test-arg %s --test-arg --match-full-lines --test-arg --check-prefix=INTERESTING --test-arg --input-file
; RUN: FileCheck %s --input-file %t.2 --check-prefixes=REDUCED
; INTERESTING: store i32 43, i32* {{(%imm|%indirect)}}, align 4 ; INTERESTING: store i32 43, i32* {{(%imm|%indirect)}}, align 4
; REDUCED: store i32 43, i32* %imm, align 4 ; REDUCED: store i32 43, i32* %imm, align 4
; INTERESTING: store i32 44, i32* {{(%imm|%indirect|%phi)}}, align 4 ; INTERESTING: store i32 44, i32* {{(%imm|%indirect|%phi)}}, align 4
; REDUCED: store i32 44, i32* %phi, align 4 ; REDUCED: store i32 44, i32* %phi, align 4
; INTERESTING: store i32 45, i32* {{(%imm|%indirect|%phi|%val)}}, align 4 ; INTERESTING: store i32 45, i32* {{(%imm|%indirect|%phi|%val)}}, align 4
; REDUCED: store i32 45, i32* %val, align 4 ; REDUCED: store i32 45, i32* %val, align 4
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines