Page MenuHomePhabricator

[libc++][doc] Updates status documents.
ClosedPublic

Authored by Mordante on Jul 26 2022, 12:20 PM.

Details

Reviewers
huixie90
philnik
Group Reviewers
Restricted Project
Commits
rG759efa763abf: [libc++][doc] Updates status documents.
Summary

Adds the papers and LWG issues voted in during the July 2022 plenary.

Note the updating of the project based statuses is left to the active
contributors of these projects.

Diff Detail

Event Timeline

Mordante created this revision.Jul 26 2022, 12:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2022, 12:20 PM
Mordante requested review of this revision.Jul 26 2022, 12:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2022, 12:20 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
huixie90 accepted this revision as: huixie90.Jul 26 2022, 1:28 PM
huixie90 added a subscriber: huixie90.
huixie90 added inline comments.
libcxx/docs/Status/Cxx2bIssues.csv
187

nit: we can claim this done as we implemented decay-copy as a macro to static_cast which doesn't have the problem the issue mentioned

Mordante added inline comments.Jul 26 2022, 1:49 PM
libcxx/docs/Status/Cxx2bIssues.csv
187

Thanks! Do you know in which version of libc++ this was fixed?

philnik accepted this revision.Jul 26 2022, 2:02 PM
philnik added a subscriber: philnik.

There are many interesting papers. LGTM % comment.

libcxx/docs/Status/Cxx2bPapers.csv
79

Why is this in here? AFAICT it only has core wording changes.

This revision is now accepted and ready to land.Jul 26 2022, 2:02 PM
huixie90 added inline comments.Jul 26 2022, 3:10 PM
libcxx/docs/Status/Cxx2bIssues.csv
187

It is this commit
https://github.com/llvm/llvm-project/commit/cb8a0b07974eb6a6aa681c30ce694e13b33a3db5

(I don't know how to find out which version though)

philnik added inline comments.Jul 26 2022, 3:26 PM
libcxx/docs/Status/Cxx2bIssues.csv
187

You can just search for the title. If you only find one commit, look at which branches it is part of (in this case, LLVM14). If there are multiple matches just check which one was cherry-picked onto a release branch and that's the correct version.

Mordante marked 4 inline comments as done.Jul 27 2022, 8:26 AM

Thanks for the reviews!

libcxx/docs/Status/Cxx2bIssues.csv
187

Thanks!

libcxx/docs/Status/Cxx2bPapers.csv
79

Good catch I thought I had removed that, but instead removed P1223R5 ranges::find_last(), ranges::find_last_if(), and ranges::find_last_if_not(). So I'll rectify that before landing.

This revision was automatically updated to reflect the committed changes.
Mordante marked 2 inline comments as done.