Page MenuHomePhabricator

[lldb][NFCI] Refactor regex filtering logic in CommandObjectTypeFormatterList
ClosedPublic

Authored by jgorbe on Jul 20 2022, 7:37 PM.

Details

Summary

Extract a bit of copy/pasted regex filtering logic into a separate function and simplify it a little bit.

Diff Detail

Event Timeline

jgorbe created this revision.Jul 20 2022, 7:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2022, 7:37 PM
jgorbe requested review of this revision.Jul 20 2022, 7:37 PM
labath accepted this revision.Jul 21 2022, 6:56 AM
labath added inline comments.
lldb/source/Commands/CommandObjectType.cpp
1064

What's up with all the parentheses? This is just a regular || between three choices...

This revision is now accepted and ready to land.Jul 21 2022, 6:56 AM
jgorbe updated this revision to Diff 446532.Jul 21 2022, 9:16 AM

Removed unnecessary parentheses.

jgorbe added inline comments.Jul 21 2022, 9:17 AM
lldb/source/Commands/CommandObjectType.cpp
1064

Thanks for catching it. Fixed.

jgorbe marked an inline comment as done.Jul 21 2022, 9:22 AM