Page MenuHomePhabricator

Simplify control variable logic for OMPT
ClosedPublic

Authored by jmellorcrummey on Sep 19 2015, 8:42 PM.

Details

Summary

Prior to this change, OMPT had a status flag ompt_status, which could take several values. This was due to an earlier OMPT design that had several levels of enablement (ready, disabled, tracking state, tracking callbacks). The current OMPT design has OMPT support either on or off.

This revision replaces ompt_status with a boolean flag ompt_enabled, which simplifies the runtime logic for OMPT.

Diff Detail

Event Timeline

jmellorcrummey retitled this revision from to Simplify control variable logic for OMPT.
jmellorcrummey updated this object.
jmellorcrummey set the repository for this revision to rL LLVM.
jmellorcrummey added a reviewer: jlpeyton.
Hahnfeld accepted this revision.Sep 21 2015, 12:54 AM
Hahnfeld added a reviewer: Hahnfeld.
Hahnfeld added a subscriber: Hahnfeld.

LGTM, finally got rid of this :-)

(has to be commited after D12998)

This revision is now accepted and ready to land.Sep 21 2015, 12:54 AM
jlpeyton accepted this revision.Sep 21 2015, 8:45 AM
jlpeyton edited edge metadata.

This LGTM as well. I'll commit this after D12998 is fixed.

This revision was automatically updated to reflect the committed changes.