This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in __support/xlocale/__nop_locale_mgmt.h header
ClosedPublic

Authored by brad on Jul 16 2022, 7:30 PM.

Details

Summary

Remove static inline and make use of _LIBCPP_HIDE_FROM_ABI in the support/xlocale/nop_locale_mgmt.h header.

Diff Detail

Event Timeline

brad created this revision.Jul 16 2022, 7:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2022, 7:30 PM
brad requested review of this revision.Jul 16 2022, 7:30 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJul 16 2022, 7:30 PM

This looks sensible to me. However I see a CI failure, can you rebase the patch and see whether it's a real failure or a glitch?

brad updated this revision to Diff 446322.Jul 20 2022, 7:36 PM

Rebase.

ldionne accepted this revision.Jul 22 2022, 9:05 AM
This revision is now accepted and ready to land.Jul 22 2022, 9:05 AM

CI issues seem unrelated.

This revision was landed with ongoing or failed builds.Jul 23 2022, 7:13 PM
This revision was automatically updated to reflect the committed changes.