This is an archive of the discontinued LLVM Phabricator instance.

Differential D129923

Visual C++ doesn't support C99 compound literal
ClosedPublic

Authored by fsb4000 on Jul 16 2022, 12:47 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG9aea9ab83dc0: Visual C++ doesn't support C99 compound literal
Summary

Fix test libcxx/test/std/containers/sequences/array/array.creation/to_array.pass.cpp

Diff Detail

Event Timeline

fsb4000 created this revision.Jul 16 2022, 12:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2022, 12:47 AM
fsb4000 requested review of this revision.Jul 16 2022, 12:47 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2022, 12:47 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B175796: Diff 445200.Jul 16 2022, 12:48 AM
fsb4000 updated this revision to Diff 445210.Jul 16 2022, 2:05 AM

another try

Harbormaster completed remote builds in B175805: Diff 445210.Jul 16 2022, 3:30 AM
fsb4000 updated this revision to Diff 445222.Jul 16 2022, 3:50 AM

use _MSVC_STL_VERSION

Harbormaster completed remote builds in B175815: Diff 445222.Jul 16 2022, 6:30 AM
Mordante accepted this revision.Jul 16 2022, 10:27 AM
Mordante added a subscriber: Mordante.

Thanks again, LGTM!

This revision is now accepted and ready to land.Jul 16 2022, 10:27 AM
Closed by commit rG9aea9ab83dc0: Visual C++ doesn't support C99 compound literal (authored by fsb4000, committed by Mordante). · Explain WhyJul 16 2022, 10:47 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG9aea9ab83dc0: Visual C++ doesn't support C99 compound literal.

Revision Contents

PathSize
libcxx/
test/
std/
containers/
sequences/
array/
array.creation/
2 lines

Diff 445210

libcxx/test/std/containers/sequences/array/array.creation/to_array.pass.cpp

Context not available.
assert(arr[i].get() == i && source[i].get() == 0); assert(arr[i].get() == i && source[i].get() == 0);
} }
#ifndef _MSC_VER
// Test C99 compound literal. // Test C99 compound literal.
{ {
auto arr = std::to_array((int[]){3, 4}); auto arr = std::to_array((int[]){3, 4});
Context not available.
assert(arr[0] == 3); assert(arr[0] == 3);
assert(arr[1] == 4); assert(arr[1] == 4);
} }
#endif // ! _MSC_VER
// Test explicit type. // Test explicit type.
{ {
Context not available.