This is an archive of the discontinued LLVM Phabricator instance.

[Fixed Point] Fix C++20 compilation error
ClosedPublic

Authored by antoniofrighetto on Jul 12 2022, 8:50 AM.

Details

Summary

Due to how operator== changed after operator<=> landing in C++20 (error: use of overloaded operator '==' is ambiguous (with operand types 'const llvm::APSInt' and 'const unsigned long')), CheckIntPartMin/CheckIntPartMax interfaces are now leveraging APSInt::compareValues.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2022, 8:50 AM
antoniofrighetto requested review of this revision.Jul 12 2022, 8:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2022, 8:50 AM
aaron.ballman accepted this revision.Jul 12 2022, 8:54 AM

LGTM assuming pre-commit CI doesn't find any unexpected surprises. Thanks for the cleanup!

This revision is now accepted and ready to land.Jul 12 2022, 8:54 AM
antoniofrighetto edited the summary of this revision. (Show Details)
aaron.ballman accepted this revision.Jul 13 2022, 5:27 AM

The precommit CI test failures are unrelated, so this LGTM now, thank you!

This revision was landed with ongoing or failed builds.Jul 13 2022, 5:39 AM
This revision was automatically updated to reflect the committed changes.