This is an archive of the discontinued LLVM Phabricator instance.

tsan: update Go x86 build rules to back off to sse3
ClosedPublic

Authored by thanm on Jul 11 2022, 5:41 AM.

Details

Summary

This is a partial revert of https://reviews.llvm.org/D106948, changing
just the Go build rules to remove -msse4.2 and revert back to -msse3,
so as to preserve support for older x86 machines. More details at
https://github.com/golang/go/issues/53743.

Diff Detail

Event Timeline

thanm created this revision.Jul 11 2022, 5:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 5:41 AM
thanm requested review of this revision.Jul 11 2022, 5:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 5:41 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
dvyukov added inline comments.Jul 11 2022, 7:49 AM
compiler-rt/lib/tsan/go/buildgo.sh
62–64

Please add some comment with references here as to why we use sse3.

dvyukov accepted this revision.Jul 11 2022, 7:49 AM

Otherwise looks good.

This revision is now accepted and ready to land.Jul 11 2022, 7:49 AM
thanm added inline comments.Jul 11 2022, 8:28 AM
compiler-rt/lib/tsan/go/buildgo.sh
62–64

Done.

thanm updated this revision to Diff 443655.Jul 11 2022, 8:34 AM

Added comments.

thanm updated this revision to Diff 443656.Jul 11 2022, 8:36 AM

Correct indentation (spaces -> tabs).

dvyukov accepted this revision.Jul 11 2022, 8:36 AM
This revision was landed with ongoing or failed builds.Jul 11 2022, 9:46 AM
This revision was automatically updated to reflect the committed changes.