This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Merge the experimental-lib-exports testcases into static-lib-exports
ClosedPublic

Authored by mstorsjo on Jul 8 2022, 2:28 PM.

Details

Summary

Since bb939931a1adb9a47a2de13c359d6a72aeb277c8, the c++experimental
library is always built, so these tested files should always be built
(even if they aren't used in tests).

Diff Detail

Event Timeline

mstorsjo created this revision.Jul 8 2022, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 2:28 PM
mstorsjo requested review of this revision.Jul 8 2022, 2:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 2:28 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision.Aug 10 2022, 9:32 AM
Mordante added a subscriber: Mordante.

LGTM, modulo some nits. Can you validate whether it still passes the CI before landing.

libcxx/test/libcxx/vendor/clang-cl/static-lib-exports.sh.cpp
11
This revision is now accepted and ready to land.Aug 10 2022, 9:32 AM
mstorsjo updated this revision to Diff 451523.Aug 10 2022, 9:39 AM

Update the comment as suggested - and rebased, rerunning CI.

libcxx/test/libcxx/vendor/clang-cl/static-lib-exports.sh.cpp