This is an archive of the discontinued LLVM Phabricator instance.

[NFC] [Coroutines] Add regression test for heap allocation elision optimization
ClosedPublic

Authored by yurai007 on Jul 7 2022, 5:00 AM.

Details

Summary

Recently C++ snippet included in this patch popped up at least twice in different regression contexts:
https://github.com/llvm/llvm-project/issues/56262 and https://reviews.llvm.org/D123300
It appears that Clang users rely on HALO so adding C++ example coming originally from Gor Nishanov to tests
should help in avoiding similar regressions in future.

Diff Detail

Event Timeline

yurai007 created this revision.Jul 7 2022, 5:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 5:00 AM
yurai007 requested review of this revision.Jul 7 2022, 5:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 5:00 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ChuanqiXu accepted this revision.Jul 7 2022, 7:02 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jul 7 2022, 7:02 PM