Page MenuHomePhabricator

yurai007 (Dawid Jurczak)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2021, 2:38 AM (75 w, 5 d)

Recent Activity

Aug 12 2022

yurai007 committed rG8a17e74ca991: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from… (authored by yurai007).
[NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from…
Aug 12 2022, 6:23 AM · Restricted Project, Restricted Project
yurai007 closed D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.
Aug 12 2022, 6:22 AM · Restricted Project, Restricted Project

Aug 11 2022

yurai007 added a comment to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

Looks good

@nikic @dblaikie @dexonsmith: Great. Thank you all for the review!

Aug 11 2022, 1:59 AM · Restricted Project, Restricted Project

Aug 10 2022

yurai007 updated the diff for D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

Rebase and adjust to C++17 (static_asserts)

Aug 10 2022, 7:51 AM · Restricted Project, Restricted Project

Aug 5 2022

yurai007 committed rG1bd31a689844: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from… (authored by yurai007).
[NFC] Add SmallVector constructor to allow creation of SmallVector<T> from…
Aug 5 2022, 4:39 AM · Restricted Project, Restricted Project
yurai007 closed D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.
Aug 5 2022, 4:38 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 updated the diff for D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.

Fix std::initializer_list lifetime issue in test case revealed on CI

Aug 5 2022, 1:54 AM · Restricted Project, Restricted Project, Restricted Project

Aug 4 2022

yurai007 planned changes to D130778: [NFC] Simplify some conversions from ArrayRef to SmallVector by using to_vector and to_vector_of utilities.
Aug 4 2022, 12:00 PM · Restricted Project, Restricted Project
yurai007 added inline comments to D130778: [NFC] Simplify some conversions from ArrayRef to SmallVector by using to_vector and to_vector_of utilities.
Aug 4 2022, 11:59 AM · Restricted Project, Restricted Project
yurai007 updated the diff for D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.

Rebase to last SmallVector NFC.

Aug 4 2022, 11:01 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 committed rG7d7a712c9861: [NFC] Define NumBuiltinElts utility just once at the beginning of… (authored by yurai007).
[NFC] Define NumBuiltinElts utility just once at the beginning of…
Aug 4 2022, 9:16 AM · Restricted Project, Restricted Project
yurai007 closed D131173: [NFC] Define NumBuiltinElts utility just once at the beginning of SmallVectorTest file.
Aug 4 2022, 9:16 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D130778: [NFC] Simplify some conversions from ArrayRef to SmallVector by using to_vector and to_vector_of utilities.
Aug 4 2022, 8:17 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.
Aug 4 2022, 7:57 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 requested review of D131173: [NFC] Define NumBuiltinElts utility just once at the beginning of SmallVectorTest file.
Aug 4 2022, 7:56 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D130778: [NFC] Simplify some conversions from ArrayRef to SmallVector by using to_vector and to_vector_of utilities.
Aug 4 2022, 7:40 AM · Restricted Project, Restricted Project
yurai007 updated the diff for D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.

Rebase and fix last comment. Remove dependency to https://reviews.llvm.org/D129781 by moving relevant part of change here.

Aug 4 2022, 7:05 AM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2022

yurai007 committed rG3d51e2727d21: [NFC] Remove some boilerplate from SmallVector unit tests (authored by yurai007).
[NFC] Remove some boilerplate from SmallVector unit tests
Aug 3 2022, 1:32 AM · Restricted Project, Restricted Project
yurai007 closed D129990: [NFC] Remove some boilerplate from SmallVector unit tests.
Aug 3 2022, 1:32 AM · Restricted Project, Restricted Project
yurai007 updated the diff for D129990: [NFC] Remove some boilerplate from SmallVector unit tests.

Rebase before merging.

Aug 3 2022, 12:19 AM · Restricted Project, Restricted Project

Aug 2 2022

yurai007 committed rG78650b786188: [NFC] Remove some boilerplate from SmallVector header (authored by yurai007).
[NFC] Remove some boilerplate from SmallVector header
Aug 2 2022, 2:48 AM · Restricted Project, Restricted Project
yurai007 closed D130779: [NFC] Remove some boilerplate from SmallVector header.
Aug 2 2022, 2:47 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.
Aug 2 2022, 1:32 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.
Aug 2 2022, 1:14 AM · Restricted Project, Restricted Project
yurai007 updated the diff for D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

Address all recent comments.

Aug 2 2022, 1:09 AM · Restricted Project, Restricted Project

Jul 31 2022

yurai007 committed rG50eb5bcfcdcd: [NFC] Remove redundant CalculateSmallVectorDefaultInlinedElements usage from… (authored by yurai007).
[NFC] Remove redundant CalculateSmallVectorDefaultInlinedElements usage from…
Jul 31 2022, 2:49 AM · Restricted Project, Restricted Project
yurai007 closed D130774: [NFC] Remove redundant CalculateSmallVectorDefaultInlinedElements usage from to_vector utility.
Jul 31 2022, 2:48 AM · Restricted Project, Restricted Project

Jul 30 2022

yurai007 committed rG65053fbc0d46: [NFC] Use more appropriate SmallVectorImpl::append call in std… (authored by yurai007).
[NFC] Use more appropriate SmallVectorImpl::append call in std…
Jul 30 2022, 1:14 AM · Restricted Project, Restricted Project
yurai007 closed D130361: [NFC] Use more appropriate SmallVectorImpl::append call in std::initializer_list SmallVector constructor.
Jul 30 2022, 1:14 AM · Restricted Project, Restricted Project

Jul 29 2022

yurai007 updated the diff for D129990: [NFC] Remove some boilerplate from SmallVector unit tests.

Move header part to separate change, leave unit tests part.

Jul 29 2022, 7:54 AM · Restricted Project, Restricted Project
yurai007 requested review of D130779: [NFC] Remove some boilerplate from SmallVector header.
Jul 29 2022, 7:47 AM · Restricted Project, Restricted Project
yurai007 abandoned D129988: [WIP] Drop SmallVector constructor taking iterator_range in favor of llvm::to_vector/llvm::to_vector_of.

Superseded by https://reviews.llvm.org/D130268

Jul 29 2022, 7:36 AM · Restricted Project, Restricted Project
yurai007 added a comment to D130778: [NFC] Simplify some conversions from ArrayRef to SmallVector by using to_vector and to_vector_of utilities.

Extracted based on comment: https://reviews.llvm.org/D129781#3685752

Jul 29 2022, 7:33 AM · Restricted Project, Restricted Project
yurai007 requested review of D130778: [NFC] Simplify some conversions from ArrayRef to SmallVector by using to_vector and to_vector_of utilities.
Jul 29 2022, 7:33 AM · Restricted Project, Restricted Project
yurai007 updated the diff for D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

Addressed comments.

Jul 29 2022, 7:11 AM · Restricted Project, Restricted Project
yurai007 added a comment to D130774: [NFC] Remove redundant CalculateSmallVectorDefaultInlinedElements usage from to_vector utility.

Extracted based on comment: https://reviews.llvm.org/D129781#inline-1257805

Jul 29 2022, 6:43 AM · Restricted Project, Restricted Project
yurai007 requested review of D130774: [NFC] Remove redundant CalculateSmallVectorDefaultInlinedElements usage from to_vector utility.
Jul 29 2022, 6:42 AM · Restricted Project, Restricted Project
yurai007 added a comment to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

Might be worth submitting this separately/without updating all the callers - so that if a caller has to be reverted for some reason we don't have to revert the functionality and testing, etc, itself? (callers could probably done in reasonable chunks - 10s, maybe 50 at a time? huge patches are a bit awkward (again, in terms of bisecting/reverting/etc) but doing one patch for each caller's probably excessive too - somewhere in between)

Jul 29 2022, 3:40 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.
Jul 29 2022, 3:35 AM · Restricted Project, Restricted Project
yurai007 added a comment to D129990: [NFC] Remove some boilerplate from SmallVector unit tests.

LGTM, but the two changes don't really seem related, so you probably want to land them separately.

Jul 29 2022, 2:45 AM · Restricted Project, Restricted Project
yurai007 added a comment to D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.

I think my only concern with this change is that it will also allow some implicit ArrayRef constructors. For example, this will permit creating a SmallVector from std::array, std::vector, or just T -- but only if ArrayRef is in scope. This seems somewhat dangerous.

Maybe I'm missing something, but is it right? It appears that only one implicit conversion in constructor is allowed: https://stackoverflow.com/questions/63320366/double-implicit-conversion-in-c
I think going from vector/array to SmallVector is ill-formed unless we explicitly create temporary ArrayRef in-between: https://godbolt.org/z/Geqbajf1x

Jul 29 2022, 2:00 AM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2022

yurai007 added a comment to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

Ping

Jul 27 2022, 11:59 PM · Restricted Project, Restricted Project

Jul 22 2022

yurai007 requested review of D130361: [NFC] Use more appropriate SmallVectorImpl::append call in std::initializer_list SmallVector constructor.
Jul 22 2022, 7:21 AM · Restricted Project, Restricted Project
yurai007 added a comment to D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.

Drop WIP tag.

Jul 22 2022, 4:07 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 retitled D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T from [WIP] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T to [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.
Jul 22 2022, 4:07 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 updated the diff for D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

Some cosmetic changes in tests.

Jul 22 2022, 4:06 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.
Jul 22 2022, 3:58 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 updated the diff for D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.

Update constructor definition with explicit to avoid implicit conversions and remove ambiguity workarounds.
Adjust constructor users and add unit tests.

Jul 22 2022, 3:51 AM · Restricted Project, Restricted Project, Restricted Project

Jul 21 2022

yurai007 added inline comments to D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.
Jul 21 2022, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 added inline comments to D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.
Jul 21 2022, 7:29 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 added a comment to D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.

Instead adding one more constructor another option is tweaking existing SmallVector(const iterator_range<RangeTy> &R) one in following way:

Jul 21 2022, 7:09 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 added inline comments to D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.
Jul 21 2022, 6:53 AM · Restricted Project, Restricted Project, Restricted Project
yurai007 requested review of D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector<T> from ArrayRef of items convertible to type T.
Jul 21 2022, 6:50 AM · Restricted Project, Restricted Project, Restricted Project

Jul 19 2022

yurai007 added a comment to D129988: [WIP] Drop SmallVector constructor taking iterator_range in favor of llvm::to_vector/llvm::to_vector_of.
Jul 19 2022, 2:53 AM · Restricted Project, Restricted Project

Jul 18 2022

yurai007 updated the diff for D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

Replace to_vector_of usage with to_vector where possible, improve names in ToVectorOf test case. All comments should be addressed now.

Jul 18 2022, 3:53 AM · Restricted Project, Restricted Project
yurai007 requested review of D129990: [NFC] Remove some boilerplate from SmallVector unit tests.
Jul 18 2022, 2:15 AM · Restricted Project, Restricted Project
yurai007 updated the summary of D129988: [WIP] Drop SmallVector constructor taking iterator_range in favor of llvm::to_vector/llvm::to_vector_of.
Jul 18 2022, 1:40 AM · Restricted Project, Restricted Project
yurai007 updated the summary of D129988: [WIP] Drop SmallVector constructor taking iterator_range in favor of llvm::to_vector/llvm::to_vector_of.
Jul 18 2022, 1:39 AM · Restricted Project, Restricted Project
yurai007 requested review of D129988: [WIP] Drop SmallVector constructor taking iterator_range in favor of llvm::to_vector/llvm::to_vector_of.
Jul 18 2022, 1:37 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.
Jul 18 2022, 12:30 AM · Restricted Project, Restricted Project

Jul 15 2022

yurai007 added a comment to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

By the way, I think it would be worthwhile to add an ArrayRef constructor to SmallVector, or else drop the existing iterator_range ctor. I've wanted to switch an iterator_range to ArrayRef a few times in the past, and always gave up due to the SmallVector fallout. We should support both or neither.

“Neither” makes some sense to me, since to_vector and to_vector_of are clear and support any range naturally. @dblaikie, any thoughts?

Yeah, I'd tend to lean that way - if std::vector doesn't have generic range-based construction, I'm happy with SmallVector not having it either.

Jul 15 2022, 9:45 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.
Jul 15 2022, 7:27 AM · Restricted Project, Restricted Project
yurai007 updated the diff for D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.

Remove WIP tag since overall direction seem to be fine and now all tests are passing (at least locally). Address some comments.

Jul 15 2022, 7:25 AM · Restricted Project, Restricted Project

Jul 14 2022

yurai007 added inline comments to D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.
Jul 14 2022, 8:44 AM · Restricted Project, Restricted Project
yurai007 requested review of D129781: [NFC] Introduce llvm::to_vector_of to allow creation of SmallVector<T> from range of items convertible to type T.
Jul 14 2022, 8:33 AM · Restricted Project, Restricted Project
yurai007 committed rGd71128d97df9: [NFC][Metadata] Change MDNode::operands()'s return type from op_range to… (authored by yurai007).
[NFC][Metadata] Change MDNode::operands()'s return type from op_range to…
Jul 14 2022, 8:23 AM · Restricted Project, Restricted Project
yurai007 closed D129565: [NFC][Metadata] Change MDNode::operands()'s return type from op_range to ArrayRef<MDOperand>.
Jul 14 2022, 8:23 AM · Restricted Project, Restricted Project

Jul 13 2022

yurai007 updated the diff for D129565: [NFC][Metadata] Change MDNode::operands()'s return type from op_range to ArrayRef<MDOperand>.

Add main one and missing operands() usage in TypeBasedAliasAnalysis

Jul 13 2022, 11:36 PM · Restricted Project, Restricted Project
yurai007 added a comment to D129565: [NFC][Metadata] Change MDNode::operands()'s return type from op_range to ArrayRef<MDOperand>.

This looks good to me, but it’d be nice to clean up further somehow later, maybe by adding a new free function.

Thanks for the review! Sure, I'm gonna continue cleaning up this with to_vector_of in next patch.

Jul 13 2022, 11:55 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D129565: [NFC][Metadata] Change MDNode::operands()'s return type from op_range to ArrayRef<MDOperand>.
Jul 13 2022, 6:30 AM · Restricted Project, Restricted Project

Jul 12 2022

yurai007 requested review of D129565: [NFC][Metadata] Change MDNode::operands()'s return type from op_range to ArrayRef<MDOperand>.
Jul 12 2022, 7:59 AM · Restricted Project, Restricted Project
yurai007 committed rG165240fe38b4: [NFC] Fix compile time regression seen on some benchmarks after a630ea3003… (authored by yurai007).
[NFC] Fix compile time regression seen on some benchmarks after a630ea3003…
Jul 12 2022, 6:03 AM · Restricted Project, Restricted Project
yurai007 closed D129468: [NFC] Fix compile time regression seen on some benchmarks after a630ea3003 commit.
Jul 12 2022, 6:02 AM · Restricted Project, Restricted Project

Jul 11 2022

yurai007 added inline comments to D129468: [NFC] Fix compile time regression seen on some benchmarks after a630ea3003 commit.
Jul 11 2022, 11:30 PM · Restricted Project, Restricted Project
yurai007 committed rGf54ca1f63264: [NFC][Coroutines] Add regression test for heap allocation elision optimization (authored by yurai007).
[NFC][Coroutines] Add regression test for heap allocation elision optimization
Jul 11 2022, 7:42 AM · Restricted Project, Restricted Project
yurai007 closed D129279: [NFC] [Coroutines] Add regression test for heap allocation elision optimization.
Jul 11 2022, 7:42 AM · Restricted Project, Restricted Project
yurai007 updated the diff for D129468: [NFC] Fix compile time regression seen on some benchmarks after a630ea3003 commit.
Jul 11 2022, 6:27 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D129468: [NFC] Fix compile time regression seen on some benchmarks after a630ea3003 commit.
Jul 11 2022, 5:45 AM · Restricted Project, Restricted Project
yurai007 updated the summary of D129468: [NFC] Fix compile time regression seen on some benchmarks after a630ea3003 commit.
Jul 11 2022, 12:14 AM · Restricted Project, Restricted Project
yurai007 requested review of D129468: [NFC] Fix compile time regression seen on some benchmarks after a630ea3003 commit.
Jul 11 2022, 12:14 AM · Restricted Project, Restricted Project

Jul 8 2022

yurai007 added inline comments to D129224: [InstCombine] Fold strtoul and strtoull and avoid PR #56293.
Jul 8 2022, 5:07 AM · Restricted Project, Restricted Project

Jul 7 2022

yurai007 requested review of D129279: [NFC] [Coroutines] Add regression test for heap allocation elision optimization.
Jul 7 2022, 5:00 AM · Restricted Project, Restricted Project

Jun 24 2022

yurai007 committed rGb7e7f4e1b6f9: [InlineCost] Improve debugging experience by adding print about initial… (authored by yurai007).
[InlineCost] Improve debugging experience by adding print about initial…
Jun 24 2022, 7:29 AM · Restricted Project, Restricted Project
yurai007 closed D127597: [InlineCost] Improve debugging experience by adding print about initial inlining cost.
Jun 24 2022, 7:29 AM · Restricted Project, Restricted Project
yurai007 added a comment to D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list..

Indeed, measuring performance is tricky and chasing slow downs can be challenging especially those at the level of ~0.2%-0.1% or less.
Personally, every time when I need to use perf on Clang I follow those short guidelines to reduce noise and get relevant numbers: https://llvm.org/docs/Benchmarking.html#linux
It contains some extra information about controlling mentioned ASLR (via *randomize_va_space), SMT, cpu isolation and more.

Jun 24 2022, 4:55 AM · Restricted Project, Restricted Project

Jun 23 2022

yurai007 added a comment to D128097: [Clang] Fix compile time regression caused by D126061..

Disclaimer: I'm not front-end guy.

Jun 23 2022, 3:18 AM · Restricted Project, Restricted Project

Jun 17 2022

yurai007 added a comment to D127597: [InlineCost] Improve debugging experience by adding print about initial inlining cost.

@nikic: Thanks for the review!

Jun 17 2022, 11:50 PM · Restricted Project, Restricted Project

Jun 12 2022

yurai007 added inline comments to D127597: [InlineCost] Improve debugging experience by adding print about initial inlining cost.
Jun 12 2022, 5:21 AM · Restricted Project, Restricted Project
yurai007 added a comment to D127597: [InlineCost] Improve debugging experience by adding print about initial inlining cost.

To put more context for this patch, while playing with LLVM Inliner I ended up with 2 very similar code snippets causing very different inlining decisions.
Looking at --debug-only=inline-cost output didn't help in figuring out what happened:

Jun 12 2022, 5:15 AM · Restricted Project, Restricted Project
yurai007 requested review of D127597: [InlineCost] Improve debugging experience by adding print about initial inlining cost.
Jun 12 2022, 5:14 AM · Restricted Project, Restricted Project

May 31 2022

yurai007 accepted D126486: [LoopIdiom] Fix bailout for aliasing in memcpy transform..

Thanks for fixing such nasty bug. Now checking whether loop access load is not only correct but also more straightforward. Maybe it would be good to receive more comments from others but since I cannot find anything wrong with this change, it's LGTM.

May 31 2022, 4:40 AM · Restricted Project, Restricted Project

May 10 2022

yurai007 committed rG009f6ce0ef1b: [GVNSink] Make GVNSink resistant against self referencing instructions (PR36954) (authored by yurai007).
[GVNSink] Make GVNSink resistant against self referencing instructions (PR36954)
May 10 2022, 7:07 AM · Restricted Project, Restricted Project
yurai007 closed D113897: [GVNSink] Make GVNSink resistant against self referencing instructions (PR36954).
May 10 2022, 7:07 AM · Restricted Project, Restricted Project
yurai007 added a comment to D113897: [GVNSink] Make GVNSink resistant against self referencing instructions (PR36954).

LGTM, though it would be good to further reduce the test case if that's possible.

Thanks a lot for review!

May 10 2022, 6:55 AM · Restricted Project, Restricted Project

May 9 2022

yurai007 updated the diff for D113897: [GVNSink] Make GVNSink resistant against self referencing instructions (PR36954).

Reduce test case even further.

May 9 2022, 8:09 AM · Restricted Project, Restricted Project

May 7 2022

yurai007 updated the diff for D113897: [GVNSink] Make GVNSink resistant against self referencing instructions (PR36954).
May 7 2022, 3:14 AM · Restricted Project, Restricted Project
yurai007 added inline comments to D113897: [GVNSink] Make GVNSink resistant against self referencing instructions (PR36954).
May 7 2022, 3:05 AM · Restricted Project, Restricted Project

May 6 2022

yurai007 added inline comments to D113897: [GVNSink] Make GVNSink resistant against self referencing instructions (PR36954).
May 6 2022, 9:23 AM · Restricted Project, Restricted Project

May 3 2022

yurai007 committed rG9c46a9cf611f: [NFC][GVNSink] Don't pretend that iteration is over instructions when it's… (authored by yurai007).
[NFC][GVNSink] Don't pretend that iteration is over instructions when it's…
May 3 2022, 8:21 AM · Restricted Project, Restricted Project
yurai007 closed D124764: [NFC][GVNSink] Don't pretend that iteration is over instructions when it's actually over blocks.
May 3 2022, 8:21 AM · Restricted Project, Restricted Project