This is an archive of the discontinued LLVM Phabricator instance.

[lldb/test] Add Shell/Expr/TestStringLiteralExpr.test
ClosedPublic

Authored by jchecahi on Jul 7 2022, 1:26 AM.

Download Raw Diff

Details

Reviewers

serge-sans-paille
JDevlieghere

Commits

rGb042d15d2e39: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

Summary

This test should exercise the usage of expressions containing
string literals and ensure that lldb doesn't crash.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jchecahi created this revision.Jul 7 2022, 1:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 1:26 AM

jchecahi requested review of this revision.Jul 7 2022, 1:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 1:26 AM

Herald added a subscriber: lldb-commits. · View Herald Transcript

jchecahi added a reviewer: serge-sans-paille.Jul 7 2022, 1:27 AM

Herald added a subscriber: JDevlieghere. · View Herald TranscriptJul 7 2022, 1:27 AM

Harbormaster completed remote builds in B174081: Diff 442815.Jul 7 2022, 1:29 AM

serge-sans-paille added a reviewer: JDevlieghere.Jul 7 2022, 1:30 AM

serge-sans-paille added inline comments.

lldb/test/Shell/Expr/TestStringLiteralExpr.test
2	This line and the one below looks like debug code and should be removed

[lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

This test should exercise the usage of expressions containing
string literals and ensure that lldb doesn't crash.

Harbormaster completed remote builds in B174084: Diff 442819.Jul 7 2022, 1:50 AM

LGTM, assuming this isn't already covered (I couldn't immediately find a test that covers string literals)

This revision is now accepted and ready to land.Jul 7 2022, 12:53 PM

I checked the test base and didn't find any similar test either.

Closed by commit rGb042d15d2e39: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test (authored by jchecahi, committed by serge-sans-paille). · Explain WhyJul 8 2022, 1:01 AM

This revision was automatically updated to reflect the committed changes.

serge-sans-paille added a commit: rGb042d15d2e39: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test.

Revision Contents

Path

Size

lldb/

test/

Shell/

Expr/

TestStringLiteralExpr.test

11 lines

Diff 442819

lldb/test/Shell/Expr/TestStringLiteralExpr.test

This file was added.

				# RUN: echo "int main() { return 0; }" \| %clang_host -x c -o %t -
				# RUN: %lldb -s %s %t \| FileCheck %s
				serge-sans-pailleUnsubmitted Not Done Reply Inline Actions This line and the one below looks like debug code and should be removed serge-sans-paille: This line and the one below looks like debug code and should be removed

				# Make sure that lldb doesn't crash when evaluating expressions with string literals
				b main
				run
				expr "hello there"
				expr printf("hello there")

				# CHECK: (const char[12]) $0 = "hello there"
				# CHECK: (int) $1 = 11