This is an archive of the discontinued LLVM Phabricator instance.

[clang-repl][NFC] Split weak symbol test to a new test
ClosedPublic

Authored by junaire on Jul 6 2022, 11:08 PM.

Details

Summary

Windows has some issues when we try to use __attribute__((weak)) in
JIT, so we disabled that. But it's not worth to disable the whole test
just for this single feature. This patch split that part from the
original test so we can keep testing stuff that normally working in
Windows.

Signed-off-by: Jun Zhang <jun@junz.org>

Diff Detail

Event Timeline

junaire created this revision.Jul 6 2022, 11:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2022, 11:08 PM
junaire requested review of this revision.Jul 6 2022, 11:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2022, 11:08 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
junaire updated this revision to Diff 442879.Jul 7 2022, 6:05 AM

Correct copy paster error

junaire updated this revision to Diff 442902.Jul 7 2022, 7:14 AM

extern printf so we can use, another copy paster mistake...

This revision is now accepted and ready to land.Jul 7 2022, 1:17 PM
This revision was landed with ongoing or failed builds.Jul 7 2022, 6:18 PM
This revision was automatically updated to reflect the committed changes.