This is an archive of the discontinued LLVM Phabricator instance.

[Compiler-RT] Remove FlushViewOfFile call when unmapping gcda files on win32.
ClosedPublic

Authored by Abpostelnicu on Jul 5 2022, 2:19 AM.

Details

Summary

This patch was pushed for calixte@mozilla.com

  • this function (Windows only) is called when gcda are dumped on disk;
  • according to its documentation, it's only useful in case of hard failures, this is highly improbable;
  • it drastically decreases the time in the tests and consequently it avoids timeouts when we use slow disks.

Diff Detail

Event Timeline

Abpostelnicu created this revision.Jul 5 2022, 2:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 2:19 AM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
Abpostelnicu requested review of this revision.Jul 5 2022, 2:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 2:19 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Abpostelnicu edited the summary of this revision. (Show Details)Jul 5 2022, 2:20 AM
Abpostelnicu added a reviewer: calixte.
Abpostelnicu added a subscriber: calixte.
calixte accepted this revision.Jul 5 2022, 4:32 AM

This patch is running for months in Firefox's CI and we didn't observe anything wrong and thanks to it we fixed several timeout issues.
I suppose that in case of hard failures, the partial ccov data are likely useless and everything will be ran again.

This revision is now accepted and ready to land.Jul 5 2022, 4:32 AM
This revision was landed with ongoing or failed builds.Jul 5 2022, 6:25 AM
This revision was automatically updated to reflect the committed changes.