This is an archive of the discontinued LLVM Phabricator instance.

[pseudo] Use the prebuilt cxx grammar for the lit tests, NFC.
ClosedPublic

Authored by hokein on Jul 4 2022, 5:19 AM.

Diff Detail

Event Timeline

hokein created this revision.Jul 4 2022, 5:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 5:19 AM
hokein requested review of this revision.Jul 4 2022, 5:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 5:19 AM

Can we make this the default value of the flag instead?

hokein added a comment.Jul 4 2022, 6:14 AM

Can we make this the default value of the flag instead?

Yeah, the default one is the cxx. But I found it is a bit clearer to explicitly mention it in the code. (also happy to remove all -grammar=%cxx-bnf-file).

sammccall accepted this revision.Jul 4 2022, 7:18 AM

Up to you.

This revision is now accepted and ready to land.Jul 4 2022, 7:18 AM