Page MenuHomePhabricator

[pseudo] Reimplement hardcoded error handling as a recovery strategy. NFC
AcceptedPublic

Authored by sammccall on Jun 29 2022, 2:30 AM.

Details

Reviewers
hokein

Diff Detail

Event Timeline

sammccall created this revision.Jun 29 2022, 2:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2022, 2:30 AM
sammccall requested review of this revision.Jun 29 2022, 2:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2022, 2:30 AM
hokein accepted this revision.Jun 29 2022, 6:39 AM
hokein added inline comments.
clang-tools-extra/pseudo/include/clang-pseudo/grammar/Grammar.h
89

I think there should be some documentation for the strategies here. (do you plan to add them when the above FIXME is fixed?)

clang-tools-extra/pseudo/lib/grammar/GrammarBNF.cpp
122

nit: use the StartSymbol global variable (we might want to rename it to Underscore).

This revision is now accepted and ready to land.Jun 29 2022, 6:39 AM