This is an archive of the discontinued LLVM Phabricator instance.

Differential D128743

StandardInstrumentation: print verifier output to errs
ClosedPublic

Authored by nhaehnle on Jun 28 2022, 10:23 AM.

Details

Reviewers
aeubanks
Commits
rG8de6d4b71294: StandardInstrumentation: print verifier output to errs
Summary

Enabling the verifiers is not very helpful if their output is
suppressed beyond the fatal error.

Diff Detail

Event Timeline

nhaehnle created this revision.Jun 28 2022, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 10:23 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
nhaehnle requested review of this revision.Jun 28 2022, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 10:23 AM
Harbormaster completed remote builds in B172531: Diff 440685.Jun 28 2022, 12:19 PM
aeubanks accepted this revision.Jun 28 2022, 1:43 PM
This revision is now accepted and ready to land.Jun 28 2022, 1:43 PM
This revision was landed with ongoing or failed builds.Jun 29 2022, 3:12 AM
Closed by commit rG8de6d4b71294: StandardInstrumentation: print verifier output to errs (authored by nhaehnle). · Explain Why
This revision was automatically updated to reflect the committed changes.
nhaehnle added a commit: rG8de6d4b71294: StandardInstrumentation: print verifier output to errs.

Revision Contents

PathSize
llvm/
lib/
Passes/
4 lines

Diff 440920

llvm/lib/Passes/StandardInstrumentations.cpp

Show First 20 Lines • Show All 1,186 Lines • ▼ Show 20 Lines PIC.registerAfterPassCallback(
const Function *F; const Function *F;
if (any_isa<const Loop *>(IR)) if (any_isa<const Loop *>(IR))
F = any_cast<const Loop *>(IR)->getHeader()->getParent(); F = any_cast<const Loop *>(IR)->getHeader()->getParent();
else else
F = any_cast<const Function *>(IR); F = any_cast<const Function *>(IR);
if (DebugLogging) if (DebugLogging)
dbgs() << "Verifying function " << F->getName() << "\n"; dbgs() << "Verifying function " << F->getName() << "\n";
if (verifyFunction(*F)) if (verifyFunction(*F, &errs()))
report_fatal_error("Broken function found, compilation aborted!"); report_fatal_error("Broken function found, compilation aborted!");
} else if (any_isa<const Module *>(IR) || } else if (any_isa<const Module *>(IR) ||
any_isa<const LazyCallGraph::SCC *>(IR)) { any_isa<const LazyCallGraph::SCC *>(IR)) {
const Module *M; const Module *M;
if (any_isa<const LazyCallGraph::SCC *>(IR)) if (any_isa<const LazyCallGraph::SCC *>(IR))
M = any_cast<const LazyCallGraph::SCC *>(IR) M = any_cast<const LazyCallGraph::SCC *>(IR)
->begin() ->begin()
->getFunction() ->getFunction()
.getParent(); .getParent();
else else
M = any_cast<const Module *>(IR); M = any_cast<const Module *>(IR);
if (DebugLogging) if (DebugLogging)
dbgs() << "Verifying module " << M->getName() << "\n"; dbgs() << "Verifying module " << M->getName() << "\n";
if (verifyModule(*M)) if (verifyModule(*M, &errs()))
report_fatal_error("Broken module found, compilation aborted!"); report_fatal_error("Broken module found, compilation aborted!");
} }
}); });
} }
InLineChangePrinter::~InLineChangePrinter() = default; InLineChangePrinter::~InLineChangePrinter() = default;
void InLineChangePrinter::generateIRRepresentation(Any IR, StringRef PassID, void InLineChangePrinter::generateIRRepresentation(Any IR, StringRef PassID,
▲ Show 20 Lines • Show All 981 Lines • Show Last 20 Lines