Add a missing "#if !SANITIZER_GO" guard for a call to DumpProcessMap
in the Finalize hook (needed to build an updated Go race detector syso
image).
Details
Details
- Reviewers
dvyukov cherry - Commits
- rG13fb97d68821: tsan: add missing guard for DumpProcessMap call
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
FYI, without this change, when I build an updated version of race_windows_amd64.syso and then run a -race test, I get:
##### Testing packages. # compress/bzip2.test C:\workdir\go\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1 c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/11.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\gopher\AppData\Local\Temp\go-link-1811237475\000002.o:gotsan.cpp:(.text+0xf949): undefined reference to `__sanitizer::DumpProcessMap()' collect2.exe: error: ld returned 1 exit status
Comment Actions
Yes, although it has been a while since I checked anything in. I'll try to dig out my notes and submit it.