Page MenuHomePhabricator

cherry (Cherry Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 19 2017, 12:47 PM (108 w, 4 d)

Recent Activity

Aug 13 2019

cherry added a comment to D66013: [X86] Emit correct unwind info for split-stack prologue.
In D66013#1627633, @wmi wrote:

I suspect there is some problem caused by interaction of .cfi_remember_state/.cfi_restore_state and CFIInstrInserter pass.

Considering the allocMBB is in the middle of the function. The CFA register is rbp instead of rsp in the prev MBB of allocMBB. At the beginning of allocMBB, CFIInstrInserter will insert a def_cfa_register to change the CFA register to rsp, which matches the state of function entry. The def_cfa_register will be inserted at the beginning of allocMBB and will be remembered by cfi_remember_state. Then .cfi_restore_state will restore the beginning of next MBB of allocMBB to have rsp instead of rbp as the CFA register, which is wrong.

Aug 13 2019, 12:46 PM · Restricted Project

Aug 9 2019

cherry created D66013: [X86] Emit correct unwind info for split-stack prologue.
Aug 9 2019, 7:20 AM · Restricted Project

Jul 18 2019

cherry accepted D64937: [NFC] include cstdint prior to using uint8_t.
Jul 18 2019, 1:15 PM · Restricted Project
cherry accepted D64937: [NFC] include cstdint prior to using uint8_t.

LGTM. Thanks.

Jul 18 2019, 11:09 AM · Restricted Project

Jul 16 2019

cherry added a comment to D64673: [X86] for split stack, not save/restore nested arg if unused.

Thanks for the review.

Jul 16 2019, 8:28 AM · Restricted Project

Jul 12 2019

cherry created D64673: [X86] for split stack, not save/restore nested arg if unused.
Jul 12 2019, 3:22 PM · Restricted Project

Mar 5 2019

cherry abandoned D55147: Exclude non-integral pointers in isBytewiseValue.
Mar 5 2019, 6:46 PM · Restricted Project
cherry accepted D59000: [SROA] Fix a crash when trying to convert a memset to an non-integral pointer type.

Looks good to me. Thanks!

Mar 5 2019, 6:43 PM · Restricted Project

Jan 17 2019

cherry added a comment to D55147: Exclude non-integral pointers in isBytewiseValue.

Also, it would be nice to fix LangRef to clarify the interaction of non-integral pointers with a known bit-pattern.

Jan 17 2019, 12:05 PM · Restricted Project
cherry updated the diff for D55147: Exclude non-integral pointers in isBytewiseValue.
Jan 17 2019, 12:02 PM · Restricted Project

Dec 14 2018

cherry added a comment to D55147: Exclude non-integral pointers in isBytewiseValue.

Hello. Is there anything I can do for this to proceed? Thank you!

Dec 14 2018, 7:29 AM · Restricted Project

Dec 11 2018

cherry added inline comments to D55147: Exclude non-integral pointers in isBytewiseValue.
Dec 11 2018, 12:47 PM · Restricted Project
cherry updated the diff for D55147: Exclude non-integral pointers in isBytewiseValue.
Dec 11 2018, 12:46 PM · Restricted Project

Dec 4 2018

cherry added inline comments to D55147: Exclude non-integral pointers in isBytewiseValue.
Dec 4 2018, 2:27 PM · Restricted Project

Dec 3 2018

cherry added inline comments to D55147: Exclude non-integral pointers in isBytewiseValue.
Dec 3 2018, 12:57 PM · Restricted Project
cherry added a comment to D55147: Exclude non-integral pointers in isBytewiseValue.

Thank you for the comment!

Dec 3 2018, 8:43 AM · Restricted Project

Nov 30 2018

cherry added inline comments to D55147: Exclude non-integral pointers in isBytewiseValue.
Nov 30 2018, 1:54 PM · Restricted Project
cherry created D55147: Exclude non-integral pointers in isBytewiseValue.
Nov 30 2018, 1:53 PM · Restricted Project
cherry added a comment to D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args.

Thanks for the review!

Nov 30 2018, 7:37 AM

Nov 29 2018

cherry added reviewers for D55072: [SelectionDAG] Generate frame index for function arg without VReg if possible: thanm, reames, niravd.
Nov 29 2018, 12:54 PM
cherry added a comment to D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args.

I think the argument, as an SSA Value, should be immutable. But here, argument at fixed frame index is, in the IR level, a pointer argument with byval attribute. We don't modify the pointer. A function could modify the content of the memory that argument points to, just like a regular pointer argument. The only difference is that we know the pointer points to a fixed stack location.

Nov 29 2018, 12:53 PM
cherry updated the diff for D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args.
Nov 29 2018, 12:53 PM
cherry added inline comments to D55072: [SelectionDAG] Generate frame index for function arg without VReg if possible.
Nov 29 2018, 12:51 PM
cherry created D55072: [SelectionDAG] Generate frame index for function arg without VReg if possible.
Nov 29 2018, 12:48 PM

Nov 28 2018

cherry added inline comments to D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args.
Nov 28 2018, 11:37 AM
cherry added inline comments to D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args.
Nov 28 2018, 9:11 AM
cherry updated the diff for D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args.
Nov 28 2018, 9:10 AM

Nov 26 2018

cherry added a comment to D53892: [CodeGen] Support custom format of stack maps.

Thank you for the review!

Nov 26 2018, 10:57 AM
cherry added a comment to D53603: [CodeGen] Take SPAdj into account for STATEPOINT liveness args.

Thank you for the review!

Nov 26 2018, 10:56 AM

Nov 20 2018

cherry added inline comments to D53892: [CodeGen] Support custom format of stack maps.
Nov 20 2018, 6:32 PM
cherry updated the diff for D53892: [CodeGen] Support custom format of stack maps.
Nov 20 2018, 6:31 PM

Nov 7 2018

cherry added a comment to D54224: [CodeGen] Expose some data types and accessors from StackMaps.

Thanks for the review!

Nov 7 2018, 2:37 PM
cherry updated the diff for D53892: [CodeGen] Support custom format of stack maps.
Nov 7 2018, 2:01 PM
cherry added a comment to D53892: [CodeGen] Support custom format of stack maps.

Thanks for the review!

Nov 7 2018, 1:59 PM
cherry created D54224: [CodeGen] Expose some data types and accessors from StackMaps.
Nov 7 2018, 1:58 PM
cherry added a comment to D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args.

Thanks for the review!

Nov 7 2018, 12:47 PM
cherry added a comment to D53602: [IRVerifier] Allow StructRet in statepoint.

Thank you for the review!

Nov 7 2018, 11:57 AM

Nov 6 2018

cherry accepted D54123: [X86] improve split-stack machine BB placement.

Patch description: s/idea/ideal/.

Nov 6 2018, 8:53 AM

Oct 30 2018

cherry created D53892: [CodeGen] Support custom format of stack maps.
Oct 30 2018, 1:36 PM
cherry created D53889: [CodeGen] Prefer static frame index for STATEPOINT liveness args.
Oct 30 2018, 1:33 PM

Oct 23 2018

cherry created D53603: [CodeGen] Take SPAdj into account for STATEPOINT liveness args.
Oct 23 2018, 12:58 PM
cherry created D53602: [IRVerifier] Allow StructRet in statepoint.
Oct 23 2018, 12:55 PM

Jun 21 2018

cherry accepted D48444: [X86] Insure split-stack prolog check is retained for sibling calls.

LGTM. Thanks.

Jun 21 2018, 10:46 AM

Feb 27 2018

cherry added a comment to D43832: [CodeGen] fix argument attribute in lowering statepoint/patchpoint.

Thanks for the review.

Feb 27 2018, 5:53 PM
cherry added reviewers for D43832: [CodeGen] fix argument attribute in lowering statepoint/patchpoint: sanjoy, rnk.
Feb 27 2018, 5:13 PM
cherry created D43832: [CodeGen] fix argument attribute in lowering statepoint/patchpoint.
Feb 27 2018, 1:22 PM

Sep 27 2017

cherry added a comment to D38051: [CodeGen] Emit necessary .note sections for -fsplit-stack.

Thank you for the review!

Sep 27 2017, 11:42 AM

Sep 20 2017

cherry added reviewers for D38051: [CodeGen] Emit necessary .note sections for -fsplit-stack: rnk, luqmana.
Sep 20 2017, 6:33 AM

Sep 19 2017

cherry created D38051: [CodeGen] Emit necessary .note sections for -fsplit-stack.
Sep 19 2017, 1:27 PM