This is an archive of the discontinued LLVM Phabricator instance.

[pseudo] Turn glrReduce into a class, reuse storage across calls.
ClosedPublic

Authored by sammccall on Jun 21 2022, 1:19 PM.

Details

Summary

This is a ~5% speedup, we no longer have to allocate the priority queues and
other collections for each reduction step where we use them.

It's also IMO easier to understand the structure of a class with methods vs a
function with nested lambdas.

Diff Detail

Event Timeline

sammccall created this revision.Jun 21 2022, 1:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2022, 1:19 PM
sammccall requested review of this revision.Jun 21 2022, 1:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2022, 1:19 PM

(Going to land this for post-commit review as a dumb mechanical change)

This revision was not accepted when it landed; it landed in state Needs Review.Jun 23 2022, 10:28 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.