[test][AlwaysInline]:Correct comment and file check for always-inline.ll

[iamarchit123]

Summary

This fixes a useless filecheck and wrong comment for always-inline.ll. Testing
has been done using ninja check-llvm and llvm-lit always-inline.ll --show-all.

[iamarchit123]

upgrade to commit

[iamarchit123]

Updating D127815: [test][AlwaysInline]:Correct comment and file check for always-inline.ll

[hoy]

llvm/test/Transforms/Inline/always-inline.ll

116

Should we have check like below after the label?

; CHECK: call void @inner6

[iamarchit123]

llvm/test/Transforms/Inline/always-inline.ll

116

Yes, that can be added but do you think the functionality that it will check gets already checked at line 131 and that is sufficient, or this CHECK will indeed check for something new?

[hoy]

LGTM, thanks.

llvm/test/Transforms/Inline/always-inline.ll

116

The check at line 131 is for a different function scope, i.e, outer6. Note that the check at line 130 signals that the checker is in outer6 scope when it is there. I was thinking about adding a check inside the inner6 scope.

On the second thought, I might misunderstand the original author's intention, which may be to check inner6 was not inlined into outer6. To that extent the current change is good.

[modimo]

llvm/test/Transforms/Inline/always-inline.ll

116

I think the intent behind the checks on inner functions is: if they are inlined, are they also successfully eliminated from IR? ; CHECK-NOT: @inner4( for example. If that's correct, then agreed this can remain as is.

llvm/test/Transforms/Inline/always-inline.ll

 }
 define void @outer2(i32 %N) {
 ; The always inliner (unlike the normal one) should be willing to inline
 ; a function with a dynamic alloca into one without a dynamic alloca.
 ; rdar://6655932
 ;
 ; CHECK-LABEL: @outer2(
 ; CHECK-NOT: call void @inner2
-; CHECK-NOT: call void @inner2
 ; CHECK: ret void
 
   call void @inner2( i32 %N )
   ret void
 }
 
 declare i32 @a() returns_twice
 declare i32 @b() returns_twice

 ; CHECK: ret
 
   %cmp = icmp slt i32 %x, 42
   %addr = select i1 %cmp, i8* blockaddress(@inner5, %one), i8* blockaddress(@inner5, %two)
   %call = call i32 @inner5(i8* %addr)
   ret i32 %call
 }
 
-; We alwaysinline a function that call itself recursively.
+; We never inline a function that calls itself recursively.
 define internal void @inner6(i32 %x) alwaysinline {
 ; CHECK-LABEL: @inner6(
 entry:
   %icmp = icmp slt i32 %x, 0
   br i1 %icmp, label %return, label %bb
 
 bb:
   %sub = sub nsw i32 %x, 1
   call void @inner6(i32 %sub)
   ret void