This is an archive of the discontinued LLVM Phabricator instance.

Differential D127794

[flang] Fix error message
ClosedPublic

Authored by klausler on Jun 14 2022, 2:03 PM.

Details

Reviewers
None
Commits
rG2815bacc9157: [flang] Fix error message
Summary

A message has a %s string substitution in it but somebody (probably me)
forgot to pass the argument that defines it.

Diff Detail

Event Timeline

klausler created this revision.Jun 14 2022, 2:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 14 2022, 2:03 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Jun 14 2022, 2:03 PM
Harbormaster completed remote builds in B169833: Diff 436929.Jun 14 2022, 3:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 15 2022, 3:30 PM
Closed by commit rG2815bacc9157: [flang] Fix error message (authored by klausler). · Explain Why
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG2815bacc9157: [flang] Fix error message.

Revision Contents

PathSize
flang/
lib/
Evaluate/
2 lines

Diff 436929

flang/lib/Evaluate/common.cpp

Context not available.
if (std::strcmp(operation, "division") == 0) { if (std::strcmp(operation, "division") == 0) {
context.messages().Say("division by zero"_warn_en_US); context.messages().Say("division by zero"_warn_en_US);
} else { } else {
context.messages().Say("division on %s"_warn_en_US); context.messages().Say("division on %s"_warn_en_US, operation);
} }
} }
if (flags.test(RealFlag::InvalidArgument)) { if (flags.test(RealFlag::InvalidArgument)) {
Context not available.