Page MenuHomePhabricator

[lldb-mi] Remove MIUtilSystem*.
ClosedPublic

Authored by brucem on Sep 10 2015, 8:14 AM.

Details

Summary

This platform-specific code wasn't fully implemented and wasn't
actually needed. There was one call for the log file path and
that has been addressed.

Diff Detail

Event Timeline

brucem updated this revision to Diff 34448.Sep 10 2015, 8:14 AM
brucem retitled this revision from to [lldb-mi] Remove MIUtilSystem*..
brucem updated this object.
brucem added reviewers: ki.stfu, domipheus, abidh.
brucem added a subscriber: lldb-commits.
abidh requested changes to this revision.Sep 10 2015, 9:25 AM
abidh edited edge metadata.

There is a check on m_strMediumFileDirectory in CMICmnLogMediumFile::FileFormFileNamePath which may needs to be updated. Otherwise looks ok to me.

This revision now requires changes to proceed.Sep 10 2015, 9:25 AM
brucem updated this revision to Diff 34514.Sep 10 2015, 5:03 PM
brucem edited edge metadata.

Removing an error check that is no longer needed and the corresponding
error message.

A broader cleanup is possible here, but I would rather do that as a
separate commit.

ki.stfu accepted this revision.Sep 10 2015, 9:36 PM
ki.stfu edited edge metadata.

lgtm

This revision was automatically updated to reflect the committed changes.

This seems to have broken 2 tests. I have to step out for about 3 hours, but will fix it when I return.

The error is not setting m_bInitialized in the Initialize method on the LogMediumFile class.

Will fix when back at computer.