[lldb-mi] Remove MIUtilSystem*.

[brucem]

Summary

This platform-specific code wasn't fully implemented and wasn't
actually needed. There was one call for the log file path and
that has been addressed.

[abidh]

There is a check on m_strMediumFileDirectory in CMICmnLogMediumFile::FileFormFileNamePath which may needs to be updated. Otherwise looks ok to me.

[brucem]

Removing an error check that is no longer needed and the corresponding
error message.

A broader cleanup is possible here, but I would rather do that as a
separate commit.

[ki.stfu]

lgtm

[brucem]

This seems to have broken 2 tests. I have to step out for about 3 hours, but will fix it when I return.

[brucem]

The error is not setting m_bInitialized in the Initialize method on the LogMediumFile class.

Will fix when back at computer.

lldb.xcodeproj/project.pbxproj

/* Begin PBXBuildFile section */
     2669423E1A6DC2AC0063BE93 /* MIDriverBase.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941DE1A6DC2AC0063BE93 /* MIDriverBase.cpp */; };
     2669423F1A6DC2AC0063BE93 /* MIDriverMain.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941E01A6DC2AC0063BE93 /* MIDriverMain.cpp */; };
     266942401A6DC2AC0063BE93 /* MIDriverMgr.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941E11A6DC2AC0063BE93 /* MIDriverMgr.cpp */; };
     266942411A6DC2AC0063BE93 /* MIUtilDateTimeStd.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941E41A6DC2AC0063BE93 /* MIUtilDateTimeStd.cpp */; };
     266942421A6DC2AC0063BE93 /* MIUtilDebug.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941E61A6DC2AC0063BE93 /* MIUtilDebug.cpp */; };
     266942431A6DC2AC0063BE93 /* MIUtilFileStd.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941E81A6DC2AC0063BE93 /* MIUtilFileStd.cpp */; };
     266942441A6DC2AC0063BE93 /* MIUtilMapIdToVariant.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941EA1A6DC2AC0063BE93 /* MIUtilMapIdToVariant.cpp */; };
     266942451A6DC2AC0063BE93 /* MIUtilString.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941EE1A6DC2AC0063BE93 /* MIUtilString.cpp */; };
-    266942461A6DC2AC0063BE93 /* MIUtilSystemLinux.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941F01A6DC2AC0063BE93 /* MIUtilSystemLinux.cpp */; };
-    266942471A6DC2AC0063BE93 /* MIUtilSystemOsx.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941F21A6DC2AC0063BE93 /* MIUtilSystemOsx.cpp */; };
-    266942481A6DC2AC0063BE93 /* MIUtilSystemWindows.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941F41A6DC2AC0063BE93 /* MIUtilSystemWindows.cpp */; };
     2669424A1A6DC2AC0063BE93 /* MIUtilThreadBaseStd.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941F81A6DC2AC0063BE93 /* MIUtilThreadBaseStd.cpp */; };
     2669424B1A6DC2AC0063BE93 /* MIUtilVariant.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941FA1A6DC2AC0063BE93 /* MIUtilVariant.cpp */; };
     2669424C1A6DC2AC0063BE93 /* Platform.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266941FC1A6DC2AC0063BE93 /* Platform.cpp */; };
     2669424D1A6DC32B0063BE93 /* LLDB.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 26680207115FD0ED008E1FE4 /* LLDB.framework */; };
     266DFE9713FD656E00D0C574 /* OperatingSystem.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266DFE9613FD656E00D0C574 /* OperatingSystem.cpp */; };
     266E82971B8CE3AC008FCA06 /* DWARFDIE.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266E82961B8CE3AC008FCA06 /* DWARFDIE.cpp */; };
     266E829D1B8E542C008FCA06 /* DWARFAttribute.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 266E829C1B8E542C008FCA06 /* DWARFAttribute.cpp */; };
     2670F8121862B44A006B332C /* libncurses.dylib in Frameworks */ = {isa = PBXBuildFile; fileRef = 2670F8111862B44A006B332C /* libncurses.dylib */; };
/* Begin PBXFileReference section */
     266941E81A6DC2AC0063BE93 /* MIUtilFileStd.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MIUtilFileStd.cpp; path = "tools/lldb-mi/MIUtilFileStd.cpp"; sourceTree = SOURCE_ROOT; };
     266941E91A6DC2AC0063BE93 /* MIUtilFileStd.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilFileStd.h; path = "tools/lldb-mi/MIUtilFileStd.h"; sourceTree = SOURCE_ROOT; };
     266941EA1A6DC2AC0063BE93 /* MIUtilMapIdToVariant.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MIUtilMapIdToVariant.cpp; path = "tools/lldb-mi/MIUtilMapIdToVariant.cpp"; sourceTree = SOURCE_ROOT; };
     266941EB1A6DC2AC0063BE93 /* MIUtilMapIdToVariant.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilMapIdToVariant.h; path = "tools/lldb-mi/MIUtilMapIdToVariant.h"; sourceTree = SOURCE_ROOT; };
     266941EC1A6DC2AC0063BE93 /* MIUtilSingletonBase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilSingletonBase.h; path = "tools/lldb-mi/MIUtilSingletonBase.h"; sourceTree = SOURCE_ROOT; };
     266941ED1A6DC2AC0063BE93 /* MIUtilSingletonHelper.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilSingletonHelper.h; path = "tools/lldb-mi/MIUtilSingletonHelper.h"; sourceTree = SOURCE_ROOT; };
     266941EE1A6DC2AC0063BE93 /* MIUtilString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MIUtilString.cpp; path = "tools/lldb-mi/MIUtilString.cpp"; sourceTree = SOURCE_ROOT; };
     266941EF1A6DC2AC0063BE93 /* MIUtilString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilString.h; path = "tools/lldb-mi/MIUtilString.h"; sourceTree = SOURCE_ROOT; };
-    266941F01A6DC2AC0063BE93 /* MIUtilSystemLinux.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MIUtilSystemLinux.cpp; path = "tools/lldb-mi/MIUtilSystemLinux.cpp"; sourceTree = SOURCE_ROOT; };
-    266941F11A6DC2AC0063BE93 /* MIUtilSystemLinux.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilSystemLinux.h; path = "tools/lldb-mi/MIUtilSystemLinux.h"; sourceTree = SOURCE_ROOT; };
-    266941F21A6DC2AC0063BE93 /* MIUtilSystemOsx.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MIUtilSystemOsx.cpp; path = "tools/lldb-mi/MIUtilSystemOsx.cpp"; sourceTree = SOURCE_ROOT; };
-    266941F31A6DC2AC0063BE93 /* MIUtilSystemOsx.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilSystemOsx.h; path = "tools/lldb-mi/MIUtilSystemOsx.h"; sourceTree = SOURCE_ROOT; };
-    266941F41A6DC2AC0063BE93 /* MIUtilSystemWindows.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MIUtilSystemWindows.cpp; path = "tools/lldb-mi/MIUtilSystemWindows.cpp"; sourceTree = SOURCE_ROOT; };
-    266941F51A6DC2AC0063BE93 /* MIUtilSystemWindows.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilSystemWindows.h; path = "tools/lldb-mi/MIUtilSystemWindows.h"; sourceTree = SOURCE_ROOT; };
     266941F81A6DC2AC0063BE93 /* MIUtilThreadBaseStd.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MIUtilThreadBaseStd.cpp; path = "tools/lldb-mi/MIUtilThreadBaseStd.cpp"; sourceTree = SOURCE_ROOT; };
     266941F91A6DC2AC0063BE93 /* MIUtilThreadBaseStd.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilThreadBaseStd.h; path = "tools/lldb-mi/MIUtilThreadBaseStd.h"; sourceTree = SOURCE_ROOT; };
     266941FA1A6DC2AC0063BE93 /* MIUtilVariant.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = MIUtilVariant.cpp; path = "tools/lldb-mi/MIUtilVariant.cpp"; sourceTree = SOURCE_ROOT; };
     266941FB1A6DC2AC0063BE93 /* MIUtilVariant.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = MIUtilVariant.h; path = "tools/lldb-mi/MIUtilVariant.h"; sourceTree = SOURCE_ROOT; };
     266941FC1A6DC2AC0063BE93 /* Platform.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = Platform.cpp; path = "tools/lldb-mi/Platform.cpp"; sourceTree = SOURCE_ROOT; };
     266941FD1A6DC2AC0063BE93 /* Platform.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = Platform.h; path = "tools/lldb-mi/Platform.h"; sourceTree = SOURCE_ROOT; };
     266960591199F4230075C61A /* build-llvm.pl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.perl; path = "build-llvm.pl"; sourceTree = "<group>"; };
     2669605A1199F4230075C61A /* build-swig-wrapper-classes.sh */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.script.sh; path = "build-swig-wrapper-classes.sh"; sourceTree = "<group>"; };
2690CD181A6DC0D000E717C8 /* lldb-mi */ = {
         266941E81A6DC2AC0063BE93 /* MIUtilFileStd.cpp */,
         266941E91A6DC2AC0063BE93 /* MIUtilFileStd.h */,
         266941EA1A6DC2AC0063BE93 /* MIUtilMapIdToVariant.cpp */,
         266941EB1A6DC2AC0063BE93 /* MIUtilMapIdToVariant.h */,
         266941EC1A6DC2AC0063BE93 /* MIUtilSingletonBase.h */,
         266941ED1A6DC2AC0063BE93 /* MIUtilSingletonHelper.h */,
         266941EE1A6DC2AC0063BE93 /* MIUtilString.cpp */,
         266941EF1A6DC2AC0063BE93 /* MIUtilString.h */,
-        266941F01A6DC2AC0063BE93 /* MIUtilSystemLinux.cpp */,
-        266941F11A6DC2AC0063BE93 /* MIUtilSystemLinux.h */,
-        266941F21A6DC2AC0063BE93 /* MIUtilSystemOsx.cpp */,
-        266941F31A6DC2AC0063BE93 /* MIUtilSystemOsx.h */,
-        266941F41A6DC2AC0063BE93 /* MIUtilSystemWindows.cpp */,
-        266941F51A6DC2AC0063BE93 /* MIUtilSystemWindows.h */,
         266941F81A6DC2AC0063BE93 /* MIUtilThreadBaseStd.cpp */,
         266941F91A6DC2AC0063BE93 /* MIUtilThreadBaseStd.h */,
         266941FA1A6DC2AC0063BE93 /* MIUtilVariant.cpp */,
         266941FB1A6DC2AC0063BE93 /* MIUtilVariant.h */,
         266941FC1A6DC2AC0063BE93 /* Platform.cpp */,
         266941FD1A6DC2AC0063BE93 /* Platform.h */,
       );
       path = "lldb-mi";
2690CD131A6DC0D000E717C8 /* Sources */ = {
         2669420B1A6DC2AC0063BE93 /* MICmdArgValThreadGrp.cpp in Sources */,
         2669420A1A6DC2AC0063BE93 /* MICmdArgValString.cpp in Sources */,
         2669421D1A6DC2AC0063BE93 /* MICmdCmdVar.cpp in Sources */,
         266942411A6DC2AC0063BE93 /* MIUtilDateTimeStd.cpp in Sources */,
         266942001A6DC2AC0063BE93 /* MICmdArgContext.cpp in Sources */,
         266942171A6DC2AC0063BE93 /* MICmdCmdStack.cpp in Sources */,
         266942121A6DC2AC0063BE93 /* MICmdCmdFile.cpp in Sources */,
         2669424B1A6DC2AC0063BE93 /* MIUtilVariant.cpp in Sources */,
-        266942471A6DC2AC0063BE93 /* MIUtilSystemOsx.cpp in Sources */,
         2669421E1A6DC2AC0063BE93 /* MICmdCommands.cpp in Sources */,
         266942161A6DC2AC0063BE93 /* MICmdCmdMiscellanous.cpp in Sources */,
         266942281A6DC2AC0063BE93 /* MICmnLLDBDebuggerHandleEvents.cpp in Sources */,
         2669421B1A6DC2AC0063BE93 /* MICmdCmdThread.cpp in Sources */,
         266942261A6DC2AC0063BE93 /* MICmnLLDBBroadcaster.cpp in Sources */,
         266942141A6DC2AC0063BE93 /* MICmdCmdGdbSet.cpp in Sources */,
         2669423F1A6DC2AC0063BE93 /* MIDriverMain.cpp in Sources */,
-        266942481A6DC2AC0063BE93 /* MIUtilSystemWindows.cpp in Sources */,
         266942041A6DC2AC0063BE93 /* MICmdArgValFile.cpp in Sources */,
         2669422D1A6DC2AC0063BE93 /* MICmnLog.cpp in Sources */,
         2669420E1A6DC2AC0063BE93 /* MICmdCmdBreak.cpp in Sources */,
         266942401A6DC2AC0063BE93 /* MIDriverMgr.cpp in Sources */,
         266942111A6DC2AC0063BE93 /* MICmdCmdExec.cpp in Sources */,
         266942061A6DC2AC0063BE93 /* MICmdArgValListOfN.cpp in Sources */,
         266942201A6DC2AC0063BE93 /* MICmdFactory.cpp in Sources */,
         266942241A6DC2AC0063BE93 /* MICmdMgrSetCmdDeleteCallback.cpp in Sources */,
2690CD131A6DC0D000E717C8 /* Sources */ = {
         2669422E1A6DC2AC0063BE93 /* MICmnLogMediumFile.cpp in Sources */,
         AFB3D2801AC262AB003B4B30 /* MICmdCmdGdbShow.cpp in Sources */,
         266942361A6DC2AC0063BE93 /* MICmnResources.cpp in Sources */,
         266942371A6DC2AC0063BE93 /* MICmnStreamStderr.cpp in Sources */,
         266942351A6DC2AC0063BE93 /* MICmnMIValueTuple.cpp in Sources */,
         2669422B1A6DC2AC0063BE93 /* MICmnLLDBProxySBValue.cpp in Sources */,
         2669423E1A6DC2AC0063BE93 /* MIDriverBase.cpp in Sources */,
         2669424C1A6DC2AC0063BE93 /* Platform.cpp in Sources */,
-        266942461A6DC2AC0063BE93 /* MIUtilSystemLinux.cpp in Sources */,
         266942021A6DC2AC0063BE93 /* MICmdArgValBase.cpp in Sources */,
         266942091A6DC2AC0063BE93 /* MICmdArgValOptionShort.cpp in Sources */,
         266942291A6DC2AC0063BE93 /* MICmnLLDBDebugSessionInfo.cpp in Sources */,
         266942211A6DC2AC0063BE93 /* MICmdInterpreter.cpp in Sources */,
         26D52C1F1A980FE300E5D2FB /* MICmdCmdSymbol.cpp in Sources */,
         266942321A6DC2AC0063BE93 /* MICmnMIValueConst.cpp in Sources */,
         2669423B1A6DC2AC0063BE93 /* MICmnStreamStdout.cpp in Sources */,
         266942271A6DC2AC0063BE93 /* MICmnLLDBDebugger.cpp in Sources */,

tools/lldb-mi/CMakeLists.txt

set(LLDB_MI_SOURCES
   MIDriverBase.cpp
   MIDriverMain.cpp
   MIDriverMgr.cpp
   MIUtilDateTimeStd.cpp
   MIUtilDebug.cpp
   MIUtilFileStd.cpp
   MIUtilMapIdToVariant.cpp
   MIUtilString.cpp
-  MIUtilSystemLinux.cpp
-  MIUtilSystemOsx.cpp
-  MIUtilSystemWindows.cpp
   MIUtilThreadBaseStd.cpp
   MIUtilVariant.cpp
   Platform.cpp
   )
 
 if ( CMAKE_SYSTEM_NAME MATCHES "Windows" )
   add_definitions( -DIMPORT_LIBLLDB )
   list(APPEND LLDB_MI_SOURCES

tools/lldb-mi/MICmnLogMediumFile.cpp

 //===-- MICmnLogMediumFile.cpp ----------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 // In-house headers:
 #include "MICmnLogMediumFile.h"
 #include "MICmnResources.h"
-#if defined(_MSC_VER)
-#include "MIUtilSystemWindows.h"
-#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__linux__)
-#include "MIUtilSystemLinux.h"
-#elif defined(__APPLE__)
-#include "MIUtilSystemOsx.h"
-#endif // defined( _MSC_VER )
 
 //++ ------------------------------------------------------------------------------------
 // Details: CMICmnLogMediumFile constructor.
 // Type:    Method.
 // Args:    None.
 // Return:  None.
 // Throws:  None.
 //--
 CMICmnLogMediumFile::CMICmnLogMediumFile()
     : m_constThisMediumName(MIRSRC(IDS_MEDIUMFILE_NAME))
     , m_constMediumFileNameFormat("lldb-mi-%s.log")
     , m_strMediumFileName(MIRSRC(IDS_MEDIUMFILE_ERR_INVALID_PATH))
-    , m_strMediumFileDirectory(MIRSRC(IDS_MEDIUMFILE_ERR_INVALID_PATH))
+    , m_strMediumFileDirectory(".")
     , m_fileNamePath(MIRSRC(IDS_MEDIUMFILE_ERR_INVALID_PATH))
     , m_eVerbosityType(CMICmnLog::eLogVerbosity_Log)
     , m_strDate(CMIUtilDateTimeStd().GetDate())
     , m_fileHeaderTxt(MIRSRC(IDS_MEDIUMFILE_ERR_FILE_HEADER))
 {
 }
 
 //++ ------------------------------------------------------------------------------------

 // Args:    None.
 // Return:  MIstatus::success - Functional succeeded.
 //          MIstatus::failure - Functional failed.
 // Throws:  None.
 //--
 bool
 CMICmnLogMediumFile::Initialize()
 {
-    m_bInitialized = CMIUtilSystem().GetLogFilesPath(m_strMediumFileDirectory);
-    m_bInitialized &= FileFormFileNamePath();
-
-    return m_bInitialized;
+    return FileFormFileNamePath();
 }
 
 //++ ------------------------------------------------------------------------------------
 // Details: Unbind detach or release resources used by *this medium.
 // Type:    Method.
 // Args:    None.
 // Return:  None.
 // Throws:  None.

tools/lldb-mi/MIUtilSystemLinux.h

-//===-- CMIUtilSystemLinux.h ------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#pragma once
-
-#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__linux__)
-
-// In-house headers:
-#include "MIUtilString.h"
-
-//++ ============================================================================
-// Details: MI common code utility class. Used to set or retrieve information
-//          about the current system or user.
-//          *** If you change, remove or add functionality it must be replicated
-//          *** for the all platforms supported; Windows, OSX, LINUX
-//--
-class CMIUtilSystemLinux
-{
-    // Methods:
-  public:
-    /* ctor */ CMIUtilSystemLinux();
-
-    bool GetOSErrorMsg(const MIint vError, CMIUtilString &vrwErrorMsg) const;
-    CMIUtilString GetOSLastError() const;
-    bool GetExecutablesPath(CMIUtilString &vrwFileNamePath) const;
-    bool GetLogFilesPath(CMIUtilString &vrwFileNamePath) const;
-
-    // Overrideable:
-  public:
-    // From CMICmnBase
-    /* dtor */ virtual ~CMIUtilSystemLinux();
-};
-
-typedef CMIUtilSystemLinux CMIUtilSystem;
-
-#endif // #if defined( __linux__ )

tools/lldb-mi/MIUtilSystemLinux.cpp

-//===-- MIUtilSystemLinux.cpp -----------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__linux__)
-
-// In-house headers:
-#include "MIUtilSystemLinux.h"
-#include "MICmnResources.h"
-
-//++ ------------------------------------------------------------------------------------
-// Details: CMIUtilSystemLinux constructor.
-// Type:    Method.
-// Args:    None.
-// Return:  None.
-// Throws:  None.
-//--
-CMIUtilSystemLinux::CMIUtilSystemLinux()
-{
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: CMIUtilSystemLinux destructor.
-// Type:    Method.
-// Args:    None.
-// Return:  None.
-// Throws:  None.
-//--
-CMIUtilSystemLinux::~CMIUtilSystemLinux()
-{
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieve the OS system error message for the given system error code.
-// Type:    Method.
-// Args:    vError      - (R) OS error code value.
-//          vrwErrorMsg - (W) The error message.
-// Return:  MIstatus::success - Functional succeeded.
-//          MIstatus::failure - Functional failed.
-// Throws:  None.
-//--
-bool
-CMIUtilSystemLinux::GetOSErrorMsg(const MIint vError, CMIUtilString &vrwErrorMsg) const
-{
-    // Reset
-    vrwErrorMsg.clear();
-
-    bool bOk = MIstatus::failure;
-
-    // ToDo: Implement LINUX version
-
-    return bOk;
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieve if possible the OS last error description.
-// Type:    Method.
-// Args:    None.
-// Return:  CMIUtilString - Error description.
-// Throws:  None.
-//--
-CMIUtilString
-CMIUtilSystemLinux::GetOSLastError() const
-{
-    CMIUtilString errorMsg("Error fn not implemented ");
-
-    // ToDo: Implement LINUX version
-
-    return errorMsg;
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieves the fully qualified path for the this application. If the function
-//          fails the string is filled with the error message.
-// Type:    Method.
-// Args:    vrwFileNamePath - (W) The executable's name and path or last error description.
-// Return:  MIstatus::success - Functional succeeded.
-//          MIstatus::failure - Functional failed.
-// Throws:  None.
-//--
-bool
-CMIUtilSystemLinux::GetExecutablesPath(CMIUtilString &vrwFileNamePath) const
-{
-    vrwFileNamePath = CMIUtilString(".");
-    return MIstatus::success;
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieves the fully qualified path for the Log file for this application.
-//          If the function fails the string is filled with the error message.
-//          Append a dummy file name on the end of the path. This will be stripped off
-//          later and the real log file name replaces it.
-// Type:    Method.
-// Args:    vrwFileNamePath - (W) The Log file's name and path or last error description.
-// Return:  MIstatus::success - Functional succeeded.
-//          MIstatus::failure - Functional failed.
-// Throws:  None.
-//--
-bool
-CMIUtilSystemLinux::GetLogFilesPath(CMIUtilString &vrwFileNamePath) const
-{
-    vrwFileNamePath = CMIUtilString(".");
-    return MIstatus::success;
-}
-
-#endif // #if defined( __linux__ )

tools/lldb-mi/MIUtilSystemOsx.h

-//===-- MICmnConfig.h -------------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#pragma once
-
-#if defined(__APPLE__)
-
-// In-house headers:
-#include "MIUtilString.h"
-
-//++ ============================================================================
-// Details: MI common code utility class. Used to set or retrieve information
-//          about the current system or user.
-//          *** If you change, remove or add functionality it must be replicated
-//          *** for the all platforms supported; Windows, OSX, LINUX
-//--
-class CMIUtilSystemOsx
-{
-    // Methods:
-  public:
-    /* ctor */ CMIUtilSystemOsx();
-
-    bool GetOSErrorMsg(const MIint vError, CMIUtilString &vrwErrorMsg) const;
-    CMIUtilString GetOSLastError() const;
-    bool GetExecutablesPath(CMIUtilString &vrwFileNamePath) const;
-    bool GetLogFilesPath(CMIUtilString &vrwFileNamePath) const;
-
-    // Overrideable:
-  public:
-    // From CMICmnBase
-    /* dtor */ virtual ~CMIUtilSystemOsx();
-};
-
-typedef CMIUtilSystemOsx CMIUtilSystem;
-
-#endif // #if defined( __APPLE__ )

tools/lldb-mi/MIUtilSystemOsx.cpp

-//===-- MIUtilSystemOsx.cpp -------------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#if defined(__APPLE__)
-
-// In-house headers:
-#include "MIUtilSystemOsx.h"
-#include "MICmnResources.h"
-
-//++ ------------------------------------------------------------------------------------
-// Details: CMIUtilSystemOsx constructor.
-// Type:    Method.
-// Args:    None.
-// Return:  None.
-// Throws:  None.
-//--
-CMIUtilSystemOsx::CMIUtilSystemOsx()
-{
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: CMIUtilSystemOsx destructor.
-// Type:    Method.
-// Args:    None.
-// Return:  None.
-// Throws:  None.
-//--
-CMIUtilSystemOsx::~CMIUtilSystemOsx()
-{
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieve the OS system error message for the given system error code.
-// Type:    Method.
-// Args:    vError    - (R) OS error code value.
-//          vrwErrorMsg - (W) The error message.
-// Return:  MIstatus::success - Functional succeeded.
-//          MIstatus::failure - Functional failed.
-// Throws:  None.
-//--
-bool
-CMIUtilSystemOsx::GetOSErrorMsg(const MIint vError, CMIUtilString &vrwErrorMsg) const
-{
-    // Reset
-    vrwErrorMsg.clear();
-
-    bool bOk = MIstatus::failure;
-
-    // ToDo: Implement LINUX version
-
-    return bOk;
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieve if possible the OS last error description.
-// Type:    Method.
-// Args:    None.
-// Return:  CMIUtilString - Error description.
-// Throws:  None.
-//--
-CMIUtilString
-CMIUtilSystemOsx::GetOSLastError() const
-{
-    CMIUtilString errorMsg("Error fn not implemented");
-
-    // ToDo: Implement LINUX version
-
-    return errorMsg;
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieves the fully qualified path for the this application. If the function
-//          fails the string is filled with the error message.
-// Type:    Method.
-// Args:    vrwFileNamePath - (W) The executable's name and path or last error description.
-// Return:  MIstatus::success - Functional succeeded.
-//          MIstatus::failure - Functional failed.
-// Throws:  None.
-//--
-bool
-CMIUtilSystemOsx::GetExecutablesPath(CMIUtilString &vrwFileNamePath) const
-{
-    vrwFileNamePath = CMIUtilString(".");
-    return MIstatus::success;
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieves the fully qualified path for the Log file for this application.
-//          If the function fails the string is filled with the error message.
-//          Append a dummy file name on the end of the path. This will be stripped off
-//          later and the real log file name replaces it.
-// Type:    Method.
-// Args:    vrwFileNamePath - (W) The Log file's name and path or last error description.
-// Return:  MIstatus::success - Functional succeeded.
-//          MIstatus::failure - Functional failed.
-// Throws:  None.
-//--
-bool
-CMIUtilSystemOsx::GetLogFilesPath(CMIUtilString &vrwFileNamePath) const
-{
-    vrwFileNamePath = CMIUtilString(".");
-    return MIstatus::success;
-}
-
-#endif // #if defined( __APPLE__ )

tools/lldb-mi/MIUtilSystemWindows.h

-//===-- MIUtilSystemWindows.h -----------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-#pragma once
-
-#if defined(_MSC_VER)
-
-// In-house headers:
-#include "MIUtilString.h"
-
-//++ ============================================================================
-// Details: MI common code utility class. Used to set or retrieve information
-//          about the current system or user.
-//          *** If you change, remove or add functionality it must be replicated
-//          *** for the all platforms supported; Windows, OSX, LINUX
-//--
-class CMIUtilSystemWindows
-{
-    // Methods:
-  public:
-    /* ctor */ CMIUtilSystemWindows();
-
-    bool GetOSErrorMsg(const MIint vError, CMIUtilString &vrwErrorMsg) const;
-    CMIUtilString GetOSLastError() const;
-    bool GetExecutablesPath(CMIUtilString &vrwFileNamePath) const;
-    bool GetLogFilesPath(CMIUtilString &vrwFileNamePath) const;
-
-    // Overrideable:
-  public:
-    // From CMICmnBase
-    /* dtor */ virtual ~CMIUtilSystemWindows();
-};
-
-typedef CMIUtilSystemWindows CMIUtilSystem;
-
-#endif // #if defined( _MSC_VER )

tools/lldb-mi/MIUtilSystemWindows.cpp

-//===-- MIUtilSystemWindows.cpp ---------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#if defined(_MSC_VER)
-
-// Third party headers
-#include <memory> // std::unique_ptr
-#include <Windows.h>
-#include <WinBase.h> // ::FormatMessage()
-
-// In-house headers:
-#include "MIUtilSystemWindows.h"
-#include "MICmnResources.h"
-#include "MIUtilFileStd.h"
-
-//++ ------------------------------------------------------------------------------------
-// Details: CMIUtilSystemWindows constructor.
-// Type:    Method.
-// Args:    None.
-// Return:  None.
-// Throws:  None.
-//--
-CMIUtilSystemWindows::CMIUtilSystemWindows()
-{
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: CMIUtilSystemWindows destructor.
-// Type:    Method.
-// Args:    None.
-// Return:  None.
-// Throws:  None.
-//--
-CMIUtilSystemWindows::~CMIUtilSystemWindows()
-{
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieve the OS system error message for the given system error code.
-// Type:    Method.
-// Args:    vError      - (R) OS error code value.
-//          vrwErrorMsg - (W) The error message.
-// Return:  MIstatus::success - Functional succeeded.
-//          MIstatus::failure - Functional failed.
-// Throws:  None.
-//--
-bool
-CMIUtilSystemWindows::GetOSErrorMsg(const MIint vError, CMIUtilString &vrwErrorMsg) const
-{
-    // Reset
-    vrwErrorMsg.clear();
-
-    const MIuint nBufLen = 1024;
-    std::unique_ptr<char[]> pBuffer;
-    pBuffer.reset(new char[nBufLen]);
-
-    // CMIUtilString Format is not used as cannot replicate the behavior of ::FormatMessage which
-    // can take into account locality while retrieving the error message from the system.
-    const int nLength = ::FormatMessage(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS, nullptr, (DWORD)vError,
-                                        MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), reinterpret_cast<LPTSTR>(&pBuffer[0]), nBufLen, nullptr);
-    bool bOk = MIstatus::success;
-    if (nLength != 0)
-        vrwErrorMsg = &pBuffer[0];
-    else
-        bOk = MIstatus::failure;
-
-    return bOk;
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieve if possible the OS last error description.
-// Type:    Method.
-// Args:    None.
-// Return:  CMIUtilString - Error description.
-// Throws:  None.
-//--
-CMIUtilString
-CMIUtilSystemWindows::GetOSLastError() const
-{
-    CMIUtilString errorMsg;
-    const DWORD dwLastError = ::GetLastError();
-    if (dwLastError != 0)
-    {
-        if (!GetOSErrorMsg(dwLastError, errorMsg))
-            errorMsg = MIRSRC(IDE_OS_ERR_RETRIEVING);
-    }
-    else
-        errorMsg = MIRSRC(IDE_OS_ERR_UNKNOWN);
-
-    return errorMsg;
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieves the fully qualified path for the this application. If the function
-//          fails the string is filled with the error message.
-// Type:    Method.
-// Args:    vrwFileNamePath   - (W) The executable's name and path or last error description.
-// Return:  MIstatus::success - Functional succeeded.
-//          MIstatus::failure - Functional failed.
-// Throws:  None.
-//--
-bool
-CMIUtilSystemWindows::GetExecutablesPath(CMIUtilString &vrwFileNamePath) const
-{
-    bool bOk = MIstatus::success;
-    HMODULE hModule = ::GetModuleHandle(nullptr);
-    char pPath[MAX_PATH];
-    if (!::GetModuleFileName(hModule, &pPath[0], MAX_PATH))
-    {
-        bOk = MIstatus::failure;
-        vrwFileNamePath = GetOSLastError();
-    }
-    else
-        vrwFileNamePath = &pPath[0];
-
-    return bOk;
-}
-
-//++ ------------------------------------------------------------------------------------
-// Details: Retrieves the fully qualified path for the Log file for this application.
-//          If the function fails the string is filled with the error message.
-// Type:    Method.
-// Args:    vrwFileNamePath   - (W) The Log file's name and path or last error description.
-// Return:  MIstatus::success - Functional succeeded.
-//          MIstatus::failure - Functional failed.
-// Throws:  None.
-//--
-bool
-CMIUtilSystemWindows::GetLogFilesPath(CMIUtilString &vrwFileNamePath) const
-{
-    vrwFileNamePath = CMIUtilString(".");
-    return MIstatus::success;
-}
-
-#endif // #if defined( _MSC_VER )