This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Removes a GCC bug work-around.
ClosedPublic

Authored by Mordante on Jun 12 2022, 2:44 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG26465c8337a7: [libc++] Removes a GCC bug work-around.
Summary

Based on the comments in [1] this should be fixed in GCC-11.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=37804

Diff Detail

Event Timeline

Mordante created this revision.Jun 12 2022, 2:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 2:44 AM
Mordante requested review of this revision.Jun 12 2022, 2:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2022, 2:44 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Why are these declarations there at all if they don't seem to be required?

libcxx/include/__tree
36–40

This looks really weird.

Mordante marked an inline comment as done.Jun 12 2022, 3:34 AM
Mordante added inline comments.
libcxx/include/__tree
36–40

Since they are used as friends, see my comment below.

889

They are used as friends here.

ldionne accepted this revision.Jun 13 2022, 7:39 AM
This revision is now accepted and ready to land.Jun 13 2022, 7:39 AM
This revision was landed with ongoing or failed builds.Jun 13 2022, 8:55 AM
This revision was automatically updated to reflect the committed changes.
Mordante marked an inline comment as done.