This is an archive of the discontinued LLVM Phabricator instance.

[LLVM] Fix Clang-tidy misc-use-override warnings, other minor fixes
ClosedPublic

Authored by Eugene.Zelenko on Sep 9 2015, 4:26 PM.

Details

Summary

I checked this patch on my own build on RHEL 6. Regressions were OK.

Please check it in if it's OK, because I don't have SVN write access.

Diff Detail

Event Timeline

Eugene.Zelenko retitled this revision from to [LLVM] Fix Clang-tidy misc-use-override warnings, other minor fixes.
Eugene.Zelenko updated this object.
Eugene.Zelenko added a reviewer: hans.
Eugene.Zelenko set the repository for this revision to rL LLVM.

Please keep the list cc'd on patches.

I have a few 80-column nits, but can fix those when committing.

For future patches, please generate the patch with more context (e.g. "git diff -U9999"); that way the context is available in Phabricator.

include/llvm/ExecutionEngine/RuntimeDyld.h
72

80 cols

lib/ExecutionEngine/MCJIT/MCJIT.h
231

This line was 80+ columns before, but we might as well fix it while here.

hans accepted this revision.Sep 9 2015, 5:13 PM
hans edited edge metadata.

LGTM

This revision is now accepted and ready to land.Sep 9 2015, 5:13 PM
This revision was automatically updated to reflect the committed changes.
hans added a comment.Sep 10 2015, 10:10 AM

Re-committed in r247298.