This is an archive of the discontinued LLVM Phabricator instance.

Differential D127362

[lldb/crashlog] Show help when the command is called without any argument
ClosedPublic

Authored by mib on Jun 8 2022, 3:59 PM.

Details

Reviewers
JDevlieghere
Commits
rG5a9fa21ce82f: [lldb/crashlog] Show help when the command is called without any argument
Summary

This patch changes the crashlog command behavior to print the help
message if no argument was provided with the command.

rdar://94576026

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib created this revision.Jun 8 2022, 3:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 3:59 PM
mib requested review of this revision.Jun 8 2022, 3:59 PM
Herald added a subscriber: lldb-commits. · View Herald TranscriptJun 8 2022, 3:59 PM
JDevlieghere accepted this revision.Jun 8 2022, 4:02 PM

LGTM with a test :-)

This revision is now accepted and ready to land.Jun 8 2022, 4:02 PM
Harbormaster completed remote builds in B168707: Diff 435373.Jun 8 2022, 4:02 PM
mib updated this revision to Diff 435383.Jun 8 2022, 4:21 PM

Add test

Harbormaster completed remote builds in B168713: Diff 435383.Jun 8 2022, 4:24 PM
JDevlieghere accepted this revision.Jun 8 2022, 4:25 PM
Closed by commit rG5a9fa21ce82f: [lldb/crashlog] Show help when the command is called without any argument (authored by mib). · Explain WhyJun 10 2022, 1:47 PM
This revision was automatically updated to reflect the committed changes.
mib added a commit: rG5a9fa21ce82f: [lldb/crashlog] Show help when the command is called without any argument.

Revision Contents

PathSize
lldb/
examples/
python/
5 lines
test/
Shell/
ScriptInterpreter/
Python/
Crashlog/
9 lines

Diff 435383

lldb/examples/python/crashlog.py

Show First 20 Lines • Show All 1,220 Lines • ▼ Show 20 Lines
for use at the LLDB command line. After a crash log has been parsed and symbolicated, a target will have been for use at the LLDB command line. After a crash log has been parsed and symbolicated, a target will have been
created that has all of the shared libraries loaded at the load addresses found in the crash log file. This allows created that has all of the shared libraries loaded at the load addresses found in the crash log file. This allows
you to explore the program as if it were stopped at the locations described in the crash log and functions can you to explore the program as if it were stopped at the locations described in the crash log and functions can
be disassembled and lookups can be performed using the addresses found in the crash log.''' be disassembled and lookups can be performed using the addresses found in the crash log.'''
return CreateSymbolicateCrashLogOptions('crashlog', description, True) return CreateSymbolicateCrashLogOptions('crashlog', description, True)
def SymbolicateCrashLogs(debugger, command_args): def SymbolicateCrashLogs(debugger, command_args):
option_parser = CrashLogOptionParser() option_parser = CrashLogOptionParser()
if not len(command_args):
option_parser.print_help()
return
try: try:
(options, args) = option_parser.parse_args(command_args) (options, args) = option_parser.parse_args(command_args)
except: except:
return return
if options.debug: if options.debug:
print('command_args = %s' % command_args) print('command_args = %s' % command_args)
print('options', options) print('options', options)
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/no-args.test

  • This file was added.
# RUN: %lldb -o 'command script import lldb.macosx.crashlog' -o 'crashlog' 2>&1 | FileCheck %s
# CHECK: "crashlog" {{.*}} commands have been installed, use the "--help" options on these commands
# CHECK: Usage: crashlog [options] <FILE> [FILE ...]
# CHECK: Symbolicate one or more darwin crash log files to provide source file and line
# CHECK: Options:
# CHECK: -h, --help show this help message and exit