This is an archive of the discontinued LLVM Phabricator instance.

Differential D127104

MachineVerifier: Add tests which are incorrectly accepted
ClosedPublic

Authored by arsenm on Jun 6 2022, 5:37 AM.

Details

Reviewers
qcolombet
MatzeB
Summary

In the process of splitting out the liveness tracking, I ran into
these cases which should have been caught. There are still missing
errors for some cases in the entry block.

Diff Detail

Unit TestsFailed

TimeTest
60,090 msx64 debian > LLVM.CodeGen/NVPTX::wmma.py

Event Timeline

arsenm created this revision.Jun 6 2022, 5:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 5:37 AM
arsenm requested review of this revision.Jun 6 2022, 5:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 5:37 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm added a parent revision: D127103: CodeGen: Split out MachineVerifier's liveness tracking.Jun 6 2022, 5:38 AM
arsenm added a child revision: D127106: llvm-reduce: Fix crashes on unreachable blocks for MIR instructions.
Harbormaster completed remote builds in B168026: Diff 434441.Jun 6 2022, 6:14 AM
MatzeB accepted this revision.Sep 13 2022, 2:25 PM
This revision is now accepted and ready to land.Sep 13 2022, 2:25 PM
arsenm updated this revision to Diff 555348.Sep 1 2023, 5:58 AM
arsenm retitled this revision from MachineVerifier: Add test which the verifier incorrectly accepted before to MachineVerifier: Add tests which are incorrectly accepted.
arsenm edited the summary of this revision. (Show Details)

Just going to push these as xfailed to get off of phabricator, need to redo the new verifier checks

Harbormaster completed remote builds in B256246: Diff 555348.Sep 1 2023, 5:59 AM
arsenm mentioned this in rG87117a2e2005: MachineVerifier: Add tests which are incorrectly accepted.Sep 1 2023, 6:07 AM
arsenm closed this revision.Sep 1 2023, 6:11 AM

87117a2e20059f476e067b0f1a5bc50473f3c08f

arsenm added a comment.Sep 1 2023, 6:11 AM

87117a2e20059f476e067b0f1a5bc50473f3c08f

Revision Contents

Diff 434441

llvm/test/MachineVerifier/register-killed-inside-loop.mir

  • This file was added.
# REQUIRES: amdgpu-registered-target
#RUN: not --crash llc -o - -mtriple=amdgcn-amd-amdhsa -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
# %1 is live out of %bb.1 through the loop edge, and therefore the kill flag is invalid.
# CHECK: *** Bad machine code: Virtual register killed in block, but needed live out. ***
---
name: kill_flag_in_loop
body: |
bb.0:
liveins: $sgpr0, $vgpr0_vgpr1
successors: %bb.1(0x80000000)
%0:sreg_32 = COPY $sgpr0
%1:sreg_32 = S_AND_B32 1, killed %0, implicit-def dead $scc
bb.1:
successors: %bb.2(0x40000000), %bb.1(0x40000000)
S_CMP_EQ_I32 killed %1:sreg_32, 1, implicit-def $scc
S_CBRANCH_SCC0 %bb.2, implicit $scc
S_BRANCH %bb.1
bb.2:
successors: %bb.3(0x80000000)
bb.3:
S_ENDPGM 0
...

llvm/test/MachineVerifier/undef-virt-reg-entry-block.mir

  • This file was added.
# XFAIL: *
# REQUIRES: amdgpu-registered-target
# RUN: not --crash llc -o - -mtriple=amdgcn-amd-amdhsa -run-pass=none -verify-machineinstrs %s
# FIXME: This should catch the undefined use of %0
---
name: undef_virtreg
body: |
bb.0:
S_ENDPGM 0, implicit %0:sreg_32
...

llvm/test/MachineVerifier/undef-virt-reg-nonentry-block.mir

  • This file was added.
# REQUIRES: amdgpu-registered-target
# RUN: not --crash llc -o - -mtriple=amdgcn-amd-amdhsa -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
# CHECK: *** Bad machine code: Virtual register defs don't dominate all uses. ***
---
name: undef_virtreg
body: |
bb.0:
bb.1:
%0:sreg_32 = S_AND_B32 1, %1:sreg_32, implicit-def dead $scc
S_ENDPGM 0, implicit %1
...