This is an archive of the discontinued LLVM Phabricator instance.

Differential D126998

[pseudo] Fix the type-parameter rule.
ClosedPublic

Authored by hokein on Jun 3 2022, 1:02 PM.

Details

Reviewers
sammccall
Commits
rGecd7ff53b533: [pseudo] Fix the type-parameter rule.
Summary

The IDENTIFIER should be optional.

Diff Detail

Event Timeline

hokein created this revision.Jun 3 2022, 1:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 1:02 PM
hokein requested review of this revision.Jun 3 2022, 1:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 1:02 PM
Herald added a subscriber: alextsao1999. · View Herald Transcript
sammccall accepted this revision.Jun 3 2022, 1:27 PM
sammccall added inline comments.
clang-tools-extra/pseudo/test/cxx/template-noid-type-parameter.cpp
1

looks like a typo in the filename

This revision is now accepted and ready to land.Jun 3 2022, 1:27 PM
Harbormaster completed remote builds in B167781: Diff 434120.Jun 3 2022, 1:48 PM
This revision was landed with ongoing or failed builds.Jun 7 2022, 1:38 AM
Closed by commit rGecd7ff53b533: [pseudo] Fix the type-parameter rule. (authored by hokein). · Explain Why
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
hokein added a commit: rGecd7ff53b533: [pseudo] Fix the type-parameter rule..

Revision Contents

PathSize
clang-tools-extra/
pseudo/
lib/
2 lines
test/
cxx/
3 lines

Diff 434120

clang-tools-extra/pseudo/lib/cxx.bnf

Show First 20 Lines • Show All 639 Lines • ▼ Show 20 Lines
template-parameter-list := template-parameter-list , template-parameter template-parameter-list := template-parameter-list , template-parameter
requires-clause := REQUIRES constraint-logical-or-expression requires-clause := REQUIRES constraint-logical-or-expression
constraint-logical-or-expression := constraint-logical-and-expression constraint-logical-or-expression := constraint-logical-and-expression
constraint-logical-or-expression := constraint-logical-or-expression || constraint-logical-and-expression constraint-logical-or-expression := constraint-logical-or-expression || constraint-logical-and-expression
constraint-logical-and-expression := primary-expression constraint-logical-and-expression := primary-expression
constraint-logical-and-expression := constraint-logical-and-expression && primary-expression constraint-logical-and-expression := constraint-logical-and-expression && primary-expression
template-parameter := type-parameter template-parameter := type-parameter
template-parameter := parameter-declaration template-parameter := parameter-declaration
type-parameter := type-parameter-key ..._opt IDENTIFIER type-parameter := type-parameter-key ..._opt IDENTIFIER_opt
type-parameter := type-parameter-key IDENTIFIER_opt = type-id type-parameter := type-parameter-key IDENTIFIER_opt = type-id
type-parameter := type-constraint ..._opt IDENTIFIER_opt type-parameter := type-constraint ..._opt IDENTIFIER_opt
type-parameter := type-constraint IDENTIFIER_opt = type-id type-parameter := type-constraint IDENTIFIER_opt = type-id
type-parameter := template-head type-parameter-key ..._opt IDENTIFIER_opt type-parameter := template-head type-parameter-key ..._opt IDENTIFIER_opt
type-parameter := template-head type-parameter-key IDENTIFIER_opt = id-expression type-parameter := template-head type-parameter-key IDENTIFIER_opt = id-expression
type-parameter-key := CLASS type-parameter-key := CLASS
type-parameter-key := TYPENAME type-parameter-key := TYPENAME
type-constraint := nested-name-specifier_opt concept-name type-constraint := nested-name-specifier_opt concept-name
▲ Show 20 Lines • Show All 101 Lines • Show Last 20 Lines

clang-tools-extra/pseudo/test/cxx/template-noid-type-parameter.cpp

  • This file was added.
// RUN: clang-pseudo -grammar=%cxx-bnf-file -source=%s --print-forest | FileCheck %s
sammccallUnsubmitted
Done
ReplyInline Actions

looks like a typo in the filename

sammccall: looks like a typo in the filename
template <typename> struct MatchParents;
// CHECK: template-parameter-list~TYPENAME := tok[2]