This is an archive of the discontinued LLVM Phabricator instance.

Differential D126992

[pseudo] Fix noptr-abstract-declarator rule.
ClosedPublic

Authored by hokein on Jun 3 2022, 12:15 PM.

Download Raw Diff

Details

Reviewers

Commits

rG58b33bc8c48a: [pseudo] Fix noptr-abstract-declarator rule.

Summary

The const-expression in the [] can be empty.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

hokein created this revision.Jun 3 2022, 12:15 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 12:15 PM

hokein requested review of this revision.Jun 3 2022, 12:15 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 12:15 PM

Herald added a subscriber: alextsao1999. · View Herald Transcript

sammccall accepted this revision.Jun 3 2022, 12:19 PM

sammccall added inline comments.

clang-tools-extra/pseudo/test/cxx/abstract-declarator.cpp
1	maybe rather call this unsized-array?

This revision is now accepted and ready to land.Jun 3 2022, 12:19 PM

Harbormaster completed remote builds in B167772: Diff 434106.Jun 3 2022, 1:03 PM

This revision was landed with ongoing or failed builds.Jun 7 2022, 1:22 AM

Closed by commit rG58b33bc8c48a: [pseudo] Fix noptr-abstract-declarator rule. (authored by hokein). · Explain Why

This revision was automatically updated to reflect the committed changes.

hokein marked an inline comment as done.

hokein added a commit: rG58b33bc8c48a: [pseudo] Fix noptr-abstract-declarator rule..

Revision Contents

Path

Size

clang-tools-extra/

pseudo/

lib/

2 lines

test/

cxx/

abstract-declarator.cpp

7 lines

Diff 434106

clang-tools-extra/pseudo/lib/cxx.bnf

	Show First 20 Lines • Show All 423 Lines • ▼ Show 20 Lines
	type-id := type-specifier-seq abstract-declarator_opt			type-id := type-specifier-seq abstract-declarator_opt
	defining-type-id := defining-type-specifier-seq abstract-declarator_opt			defining-type-id := defining-type-specifier-seq abstract-declarator_opt
	abstract-declarator := ptr-abstract-declarator			abstract-declarator := ptr-abstract-declarator
	abstract-declarator := noptr-abstract-declarator_opt parameters-and-qualifiers trailing-return-type			abstract-declarator := noptr-abstract-declarator_opt parameters-and-qualifiers trailing-return-type
	abstract-declarator := abstract-pack-declarator			abstract-declarator := abstract-pack-declarator
	ptr-abstract-declarator := noptr-abstract-declarator			ptr-abstract-declarator := noptr-abstract-declarator
	ptr-abstract-declarator := ptr-operator ptr-abstract-declarator_opt			ptr-abstract-declarator := ptr-operator ptr-abstract-declarator_opt
	noptr-abstract-declarator := noptr-abstract-declarator_opt parameters-and-qualifiers			noptr-abstract-declarator := noptr-abstract-declarator_opt parameters-and-qualifiers
	noptr-abstract-declarator := noptr-abstract-declarator_opt [ constant-expression ]			noptr-abstract-declarator := noptr-abstract-declarator_opt [ constant-expression_opt ]
	noptr-abstract-declarator := ( ptr-abstract-declarator )			noptr-abstract-declarator := ( ptr-abstract-declarator )
	abstract-pack-declarator := noptr-abstract-pack-declarator			abstract-pack-declarator := noptr-abstract-pack-declarator
	abstract-pack-declarator := ptr-operator abstract-pack-declarator			abstract-pack-declarator := ptr-operator abstract-pack-declarator
	noptr-abstract-pack-declarator := noptr-abstract-pack-declarator parameters-and-qualifiers			noptr-abstract-pack-declarator := noptr-abstract-pack-declarator parameters-and-qualifiers
	noptr-abstract-pack-declarator := noptr-abstract-pack-declarator [ constant-expression_opt ]			noptr-abstract-pack-declarator := noptr-abstract-pack-declarator [ constant-expression_opt ]
	noptr-abstract-pack-declarator := ...			noptr-abstract-pack-declarator := ...
	#! Custom modifications to avoid nullable clause.			#! Custom modifications to avoid nullable clause.
	parameter-declaration-clause := parameter-declaration-list			parameter-declaration-clause := parameter-declaration-list
	▲ Show 20 Lines • Show All 312 Lines • Show Last 20 Lines

clang-tools-extra/pseudo/test/cxx/abstract-declarator.cpp

This file was added.

				// RUN: clang-pseudo -grammar=%cxx-bnf-file -source=%s --print-forest \| FileCheck %s
				sammccallUnsubmitted Done Reply Inline Actions maybe rather call this unsized-array? sammccall: maybe rather call this unsized-array?
				void s(int[]);
				// CHECK: parameter-declaration-list~parameter-declaration := decl-specifier-seq abstract-declarator
				// CHECK-NEXT: ├─decl-specifier-seq~INT := tok[3]
				// CHECK-NEXT: └─abstract-declarator~noptr-abstract-declarator := [ ]
				// CHECK-NEXT: ├─[ := tok[4]
				// CHECK-NEXT: └─] := tok[5]