This is an archive of the discontinued LLVM Phabricator instance.

Differential D126991

[pseudo] Fix the member-specification grammar rule.
ClosedPublic

Authored by hokein on Jun 3 2022, 12:06 PM.

Details

Reviewers
sammccall
Commits
rG0a6a17a4f9fd: [pseudo] Fix the member-specification grammar rule.
Summary

The grammar rule is not right, doesn't match the standard one.

Diff Detail

Event Timeline

hokein created this revision.Jun 3 2022, 12:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 12:06 PM
hokein requested review of this revision.Jun 3 2022, 12:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 12:06 PM
Herald added a subscriber: alextsao1999. · View Herald Transcript
sammccall accepted this revision.Jun 3 2022, 12:21 PM
This revision is now accepted and ready to land.Jun 3 2022, 12:21 PM
Harbormaster completed remote builds in B167768: Diff 434101.Jun 3 2022, 12:22 PM
This revision was landed with ongoing or failed builds.Jun 7 2022, 1:20 AM
Closed by commit rG0a6a17a4f9fd: [pseudo] Fix the member-specification grammar rule. (authored by hokein). · Explain Why
This revision was automatically updated to reflect the committed changes.
hokein added a commit: rG0a6a17a4f9fd: [pseudo] Fix the member-specification grammar rule..

Revision Contents

PathSize
clang-tools-extra/
pseudo/
lib/
2 lines
test/
cxx/
13 lines

Diff 434101

clang-tools-extra/pseudo/lib/cxx.bnf

Show First 20 Lines • Show All 531 Lines • ▼ Show 20 Lines
class-head := class-key class-head-name class-virt-specifier_opt base-clause_opt class-head := class-key class-head-name class-virt-specifier_opt base-clause_opt
class-head := class-key base-clause_opt class-head := class-key base-clause_opt
class-head-name := nested-name-specifier_opt class-name class-head-name := nested-name-specifier_opt class-name
class-virt-specifier := contextual-final class-virt-specifier := contextual-final
class-key := CLASS class-key := CLASS
class-key := STRUCT class-key := STRUCT
class-key := UNION class-key := UNION
member-specification := member-declaration member-specification_opt member-specification := member-declaration member-specification_opt
member-specification := access-specifier : member-declaration member-specification_opt member-specification := access-specifier : member-specification_opt
member-declaration := decl-specifier-seq_opt member-declarator-list_opt ; member-declaration := decl-specifier-seq_opt member-declarator-list_opt ;
member-declaration := function-definition member-declaration := function-definition
member-declaration := using-declaration member-declaration := using-declaration
member-declaration := using-enum-declaration member-declaration := using-enum-declaration
member-declaration := static_assert-declaration member-declaration := static_assert-declaration
member-declaration := template-declaration member-declaration := template-declaration
member-declaration := explicit-specialization member-declaration := explicit-specialization
member-declaration := deduction-guide member-declaration := deduction-guide
▲ Show 20 Lines • Show All 204 Lines • Show Last 20 Lines

clang-tools-extra/pseudo/test/cxx/empty-member-spec.cpp

  • This file was added.
// RUN: clang-pseudo -grammar=%cxx-bnf-file -source=%s --print-forest | FileCheck %s
class Foo {
public:
};
// CHECK: decl-specifier-seq~class-specifier := class-head { member-specification }
// CHECK-NEXT: ├─class-head := class-key class-head-name
// CHECK-NEXT: │ ├─class-key~CLASS := tok[0]
// CHECK-NEXT: │ └─class-head-name~IDENTIFIER := tok[1]
// CHECK-NEXT: ├─{ := tok[2]
// CHECK-NEXT: ├─member-specification := access-specifier :
// CHECK-NEXT: │ ├─access-specifier~PUBLIC := tok[3]
// CHECK-NEXT: │ └─: := tok[4]
// CHECK-NEXT: └─} := tok[5]