This is an archive of the discontinued LLVM Phabricator instance.

Differential D126609

[libc++] Add missing includes in __type_traits/is_unsigned.h
ClosedPublic

Authored by philnik on May 29 2022, 1:17 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGebb6f3ce370c: [libc++] Adds missing includes.

Diff Detail

Event Timeline

philnik created this revision.May 29 2022, 1:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2022, 1:17 AM
philnik requested review of this revision.May 29 2022, 1:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2022, 1:17 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.May 29 2022, 2:13 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGebb6f3ce370c: [libc++] Adds missing includes. (authored by Mordante). · Explain Why
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGebb6f3ce370c: [libc++] Adds missing includes..
Harbormaster completed remote builds in B166806: Diff 432769.May 29 2022, 3:35 AM
Mordante added a subscriber: Mordante.May 29 2022, 6:12 AM

I see you provided the same fix as the one I landed earlier today.
I'm somewhat surprised phabricator connects my commit to your patch.

philnik added a comment.May 29 2022, 6:18 AM
In D126609#3544473, @Mordante wrote:

I see you provided the same fix as the one I landed earlier today.
I'm somewhat surprised phabricator connects my commit to your patch.

I was surprised too. The patch is probably identical.

Mordante added a comment.May 29 2022, 6:22 AM

Yes the changes are identical, which in this case isn't a real surprise ;-)

Revision Contents

PathSize
libcxx/
include/
__type_traits/
2 lines

Diff 432770

libcxx/include/__type_traits/is_unsigned.h

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___TYPE_TRAITS_IS_UNSIGNED_H #ifndef _LIBCPP___TYPE_TRAITS_IS_UNSIGNED_H
#define _LIBCPP___TYPE_TRAITS_IS_UNSIGNED_H #define _LIBCPP___TYPE_TRAITS_IS_UNSIGNED_H
#include <__config> #include <__config>
#include <__type_traits/integral_constant.h> #include <__type_traits/integral_constant.h>
#include <__type_traits/is_arithmetic.h>
#include <__type_traits/is_integral.h>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
// Before Clang 13, __is_unsigned returned true for enums with signed underlying type. // Before Clang 13, __is_unsigned returned true for enums with signed underlying type.
Show All 38 Lines