This is an archive of the discontinued LLVM Phabricator instance.

Differential D12642

Improve portability, fix build issue on NetBSD
ClosedPublic

Authored by krytarowski on Sep 4 2015, 1:19 PM.

Details

Reviewers
joerg
Commits
rG737e7d68bceb: Don't use bashism/kshism of test ==. From Kamil Rytarowski.
rL247512: Don't use bashism/kshism of test ==. From Kamil Rytarowski.
Summary

The "test" command, as well as the "[" command, are not required to know the "==" operator. Only a few implementations like bash and some versions of ksh support it.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski updated this revision to Diff 34066.Sep 4 2015, 1:19 PM
krytarowski retitled this revision from to Improve portability, fix build issue on NetBSD.
krytarowski updated this object.
krytarowski added a reviewer: joerg.
krytarowski set the repository for this revision to rL LLVM.
krytarowski added a subscriber: llvm-commits.

Of course we need to regenerate later autotools.

krytarowski added a comment.Sep 9 2015, 6:47 PM

Still valid.

Closed by commit rL247512: Don't use bashism/kshism of test ==. From Kamil Rytarowski. (authored by joerg). · Explain WhySep 12 2015, 9:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
autoconf/
2 lines

Diff 34066

autoconf/configure.ac

Context not available.
fi fi
dnl Quit if it is an in-source build dnl Quit if it is an in-source build
if test ${srcdir} == "." ; then if test ${srcdir} = "." ; then
AC_MSG_ERROR([In-source builds are not allowed. Please configure from a separate build directory!]) AC_MSG_ERROR([In-source builds are not allowed. Please configure from a separate build directory!])
fi fi
Context not available.