This is an archive of the discontinued LLVM Phabricator instance.

[Fortran] Forward NO_STOP_MESSAGE to FCVS tests
ClosedPublic

Authored by rovka on May 25 2022, 2:06 AM.

Details

Summary

By default, Flang outputs 'Fortran STOP' as part of the STOP statement,
and sometimes also warnings about signaling exceptions, which are
platform-dependent. This output will cause test failures, but it can be
suppressed by setting the environment variable NO_STOP_MESSAGE=1. This
patch makes sure that llvm-lit forwards the NO_STOP_MESSAGE variable to
the tests if it is set in the environment.

Diff Detail

Repository
rT test-suite

Event Timeline

rovka created this revision.May 25 2022, 2:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2022, 2:06 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
rovka requested review of this revision.May 25 2022, 2:06 AM
rovka added a comment.May 25 2022, 2:25 AM

This is an alternative to https://reviews.llvm.org/D126279
I personally prefer the other patch, for reasons which I've explained there.
If we go with this approach, I'll also send a patch to the docs to document the need for setting this environment variable.

klausler accepted this revision.May 25 2022, 11:05 AM
This revision is now accepted and ready to land.May 25 2022, 11:05 AM

This solution looks reasonable for stop messages. I presume it kicks in when running individual tests as well as the suite.

Perhaps we can change the default settings for flang not to announce the signaling exceptions? I am not sure if this change would be to the driver or the runtime. Perhaps someone else can weigh in?

This revision was automatically updated to reflect the committed changes.