This is an archive of the discontinued LLVM Phabricator instance.

[Clang] Make PIC check comprehensive with respect to relocation models.
Needs ReviewPublic

Authored by ZhiyaoMa98 on May 24 2022, 5:09 PM.

Reviewers

rsmith
llvm-commits

Summary

Add missing if branch for "ropi", "rwpi" and "ropi-rwpi" relocation model when initializing the PIC boolean variable.

ZhiyaoMa98 requested review of this revision.May 24 2022, 5:09 PM

Path

Size

clang/

tools/

driver/

6 lines

Show First 20 Lines • Show All 397 Lines • ▼ Show 20 Lines	static bool ExecuteAssemblerImpl(AssemblerInvocation &Opts,
MCContext Ctx(Triple(Opts.Triple), MAI.get(), MRI.get(), STI.get(), &SrcMgr,		MCContext Ctx(Triple(Opts.Triple), MAI.get(), MRI.get(), STI.get(), &SrcMgr,
&MCOptions);		&MCOptions);

bool PIC = false;		bool PIC = false;
if (Opts.RelocationModel == "static") {		if (Opts.RelocationModel == "static") {
PIC = false;		PIC = false;
} else if (Opts.RelocationModel == "pic") {		} else if (Opts.RelocationModel == "pic") {
PIC = true;		PIC = true;
		} else if (Opts.RelocationModel == "ropi-rwpi") {
		PIC = true;
		} else if (Opts.RelocationModel == "ropi") {
		PIC = false;
		} else if (Opts.RelocationModel == "rwpi") {
		PIC = false;
} else {		} else {
assert(Opts.RelocationModel == "dynamic-no-pic" &&		assert(Opts.RelocationModel == "dynamic-no-pic" &&
"Invalid PIC model!");		"Invalid PIC model!");
PIC = false;		PIC = false;
}		}

// FIXME: This is not pretty. MCContext has a ptr to MCObjectFileInfo and		// FIXME: This is not pretty. MCContext has a ptr to MCObjectFileInfo and
// MCObjectFileInfo needs a MCContext reference in order to initialize itself.		// MCObjectFileInfo needs a MCContext reference in order to initialize itself.
▲ Show 20 Lines • Show All 220 Lines • Show Last 20 Lines