This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Fix add_new_check.py.
ClosedPublic

Authored by curdeius on Sep 4 2015, 1:06 AM.

Details

Reviewers
alexfh
Summary

This fixes the case where the check should be added at the end of the list of checks in CMakeLists.txt of the corresponding module.
Before it was added after LINK_LIBS line.

Diff Detail

Event Timeline

curdeius updated this revision to Diff 34017.Sep 4 2015, 1:06 AM
curdeius retitled this revision from to Fix add_new_check.py..
curdeius updated this object.
curdeius added a reviewer: alexfh.
curdeius set the repository for this revision to rL LLVM.
curdeius retitled this revision from Fix add_new_check.py. to [clang-tidy] Fix add_new_check.py..Sep 4 2015, 1:06 AM
alexfh accepted this revision.Sep 4 2015, 6:20 AM
alexfh edited edge metadata.

Looks good. Thank you for the fix!

This revision is now accepted and ready to land.Sep 4 2015, 6:20 AM

Can you land it please?
I don't have write access.

Thanks in advance!

Marek Kurdej

alexfh closed this revision.Sep 4 2015, 7:58 AM

Can you land it please?

Sure. Committed revision 246854.