This is an archive of the discontinued LLVM Phabricator instance.

Differential D12616

Failing test highlighting no poisoning if dtor undeclared.
ClosedPublic

Authored by nmusgrave on Sep 3 2015, 4:43 PM.

Details

Reviewers
kcc
eugenis
Commits
rG4e213984ddd2: Failing test highlighting no poisoning if dtor undeclared.
rC247025: Failing test highlighting no poisoning if dtor undeclared.
Summary

If class or struct has not declared a destructor,
no destsructor is emitted, and members are not poisoned
after destruction. This case highlights bug in current
implementation of use-after-dtor poisoning.

Diff Detail

Event Timeline

nmusgrave updated this revision to Diff 33989.Sep 3 2015, 4:43 PM
nmusgrave retitled this revision from to Failing test highlighting no poisoning if dtor undeclared..
nmusgrave updated this object.
nmusgrave added reviewers: eugenis, kcc.
nmusgrave added a subscriber: cfe-commits.
eugenis added inline comments.Sep 3 2015, 4:48 PM
test/CodeGenCXX/sanitize-dtor-generated.cpp
5

Add the link to the issue.

18

Why include NonTrivial in this test at all?
With just Trivial, all the checks could be replaced with just one
// CHECK: call void @__sanitizer_dtor_callback

nmusgrave updated this revision to Diff 34094.Sep 4 2015, 5:04 PM
nmusgrave marked an inline comment as done.
  • Only check simplest object for existence of sanitizing callback.
eugenis accepted this revision.Sep 4 2015, 5:06 PM
eugenis edited edge metadata.

I'd call the test sanitize-dtor-trivial.cpp

This revision is now accepted and ready to land.Sep 4 2015, 5:06 PM
nmusgrave updated this revision to Diff 34220.Sep 8 2015, 8:11 AM
nmusgrave marked an inline comment as done.
nmusgrave edited edge metadata.
  • Rename test.
nmusgrave closed this revision.Sep 8 2015, 9:40 AM

Revision Contents

PathSize
test/
CodeGenCXX/
32 lines

Diff 33989

test/CodeGenCXX/sanitize-dtor-generated.cpp

  • This file was added.
// Test -fsanitize-memory-use-after-dtor
// RUN: %clang_cc1 -O0 -fsanitize=memory -fsanitize-memory-use-after-dtor -disable-llvm-optzns -std=c++11 -triple=x86_64-pc-linux -emit-llvm -o - %s | FileCheck %s
// RUN: %clang_cc1 -O1 -fsanitize=memory -fsanitize-memory-use-after-dtor -disable-llvm-optzns -std=c++11 -triple=x86_64-pc-linux -emit-llvm -o - %s | FileCheck %s
// TODO Success pending on resolution of issue 596
eugenisUnsubmitted
Done
ReplyInline Actions

Add the link to the issue.

eugenis: Add the link to the issue.
// XFAIL: *
template <class T> class Vector {
public:
int size;
~Vector() {}
};
struct NonTrivial {
int a;
Vector<int> v;
};
NonTrivial nt;
eugenisUnsubmitted
Done
ReplyInline Actions

Why include NonTrivial in this test at all?
With just Trivial, all the checks could be replaced with just one
// CHECK: call void @__sanitizer_dtor_callback

eugenis: Why include NonTrivial in this test at all? With just Trivial, all the checks could be replaced…
struct Trivial {
int a;
int b;
};
Trivial t;
// CHECK-LABEL: define {{.*}}NonTrivialD2Ev
// CHECK: call void @__sanitizer_dtor_callback
// CHECK: ret void
// CHECK-LABEL: define {{.*}}TrivialD2Ev
// CHECK: call void @__sanitizer_dtor_callback
// CHECK: ret void