Remove `friend` classes from TypeCategoryMap

[jgorbe]

Summary

As far as I can tell, the only thing those friend classes access is the
ValueSP typedef.

Given that this is a map-ish class, with "Map" in its name, it doesn't seem like
a stretch to make KeyType, ValueType and ValueSP public. More so when the
public methods of the class have KeyType and ValueSP arguments and clearly
ValueSP needs to be accessed from the outside.

friend complicates local reasoning about who can access private members, which
is valuable in a class like this that has every method locking a mutex to
prevent concurrent access.

[JDevlieghere]

LGTM

lldb/include/lldb/DataFormatters/TypeCategoryMap.h

 #include "lldb/lldb-public.h"
 
 #include "lldb/DataFormatters/FormattersContainer.h"
 #include "lldb/DataFormatters/TypeCategory.h"
 
 namespace lldb_private {
 class TypeCategoryMap {
 private:
-  typedef ConstString KeyType;
-  typedef TypeCategoryImpl ValueType;
-  typedef ValueType::SharedPointer ValueSP;
   typedef std::list<lldb::TypeCategoryImplSP> ActiveCategoriesList;
   typedef ActiveCategoriesList::iterator ActiveCategoriesIterator;
 
 public:
+  typedef ConstString KeyType;
+  typedef TypeCategoryImpl ValueType;
+  typedef ValueType::SharedPointer ValueSP;
   typedef std::map<KeyType, ValueSP> MapType;
   typedef MapType::iterator MapIterator;
   typedef std::function<bool(const ValueSP &)> ForEachCallback;
 
   typedef uint32_t Position;
 
   static const Position First = 0;
   static const Position Default = 1;
private:
   MapType m_map;
   ActiveCategoriesList m_active_categories;
 
   MapType &map() { return m_map; }
 
   ActiveCategoriesList &active_list() { return m_active_categories; }
 
   std::recursive_mutex &mutex() { return m_map_mutex; }
-
-  friend class FormattersContainer<ValueType>;
-  friend class FormatManager;
 };
 } // namespace lldb_private
 
 #endif // LLDB_DATAFORMATTERS_TYPECATEGORYMAP_H