This is an archive of the discontinued LLVM Phabricator instance.

Differential D126076

[lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS)
ClosedPublic

Authored by JDevlieghere on May 20 2022, 9:31 AM.

Details

Reviewers
jasonmolenda
Commits
rGa1cf154dd476: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS)
Summary

Report the correct register number (GENERIC_REGNUM_FLAGS) for cpsr. This fixes TestLldbGdbServer.py on Apple Silicon.

Diff Detail

Event Timeline

JDevlieghere created this revision.May 20 2022, 9:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 9:31 AM
JDevlieghere requested review of this revision.May 20 2022, 9:31 AM
Harbormaster completed remote builds in B165541: Diff 430999.May 20 2022, 9:34 AM
jasonmolenda accepted this revision.May 20 2022, 9:34 AM

Ah, good catch!

This revision is now accepted and ready to land.May 20 2022, 9:34 AM
Closed by commit rGa1cf154dd476: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS) (authored by JDevlieghere). · Explain WhyMay 20 2022, 9:37 AM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rGa1cf154dd476: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS).
Herald added a project: Restricted Project. · View Herald TranscriptMay 20 2022, 9:37 AM

Revision Contents

PathSize
lldb/
tools/
debugserver/
source/
MacOSX/
arm64/
2 lines

Diff 430999

lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp

Context not available.
// used for // used for
// userland debugging. // userland debugging.
{e_regSetGPR, gpr_cpsr, "cpsr", "flags", Uint, Hex, 4, {e_regSetGPR, gpr_cpsr, "cpsr", "flags", Uint, Hex, 4,
GPR_OFFSET_NAME(cpsr), dwarf_elr_mode, dwarf_elr_mode, INVALID_NUB_REGNUM, GPR_OFFSET_NAME(cpsr), dwarf_elr_mode, dwarf_elr_mode, GENERIC_REGNUM_FLAGS,
debugserver_gpr_cpsr, NULL, NULL}, debugserver_gpr_cpsr, NULL, NULL},
DEFINE_PSEUDO_GPR_IDX(0, w0), DEFINE_PSEUDO_GPR_IDX(0, w0),
Context not available.