This is an archive of the discontinued LLVM Phabricator instance.

AVX512 : vcmpss/sd implementation
ClosedPublic

Authored by igorb on Sep 3 2015, 3:54 AM.

Details

Summary

AVX512: Implemented encoding and intrinsics for vcmpss/sd.
Added tests for intrinsics and encoding.

Diff Detail

Repository
rL LLVM

Event Timeline

igorb updated this revision to Diff 33925.Sep 3 2015, 3:54 AM
igorb retitled this revision from to AVX512 : vcmpss/sd implementation.
igorb updated this object.
igorb added reviewers: delena, AsafBadouh.
igorb set the repository for this revision to rL LLVM.
igorb added a subscriber: llvm-commits.
delena added inline comments.Sep 19 2015, 11:50 PM
lib/Target/X86/X86ISelLowering.cpp
15889

It should be SIGN_EXTEND here.

lib/Target/X86/X86InstrFragmentsSIMD.td
171

Try to use the same FSETCC node with different number of parameters.

test/CodeGen/X86/avx512-intrinsics.ll
3989

Please use logical ops here "and" / "or".

igorb updated this revision to Diff 35197.Sep 20 2015, 6:17 AM
igorb marked 3 inline comments as done.
delena added inline comments.Sep 20 2015, 6:42 AM
lib/Target/X86/X86ISelLowering.cpp
15527

Please use "if" here.

15891

ZERO_EXTEND -> ANY_EXTEND

igorb updated this revision to Diff 35198.Sep 20 2015, 7:15 AM
igorb marked 2 inline comments as done.
This revision was automatically updated to reflect the committed changes.